1464006 - Move Normandy FilterExpressions to toolkit/components/utils

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement)

Description

[Mathieu Leplatre [:leplatrem]]

Since Normandy is only included in browser builds, we should move the FilterExpressions module to a place that is included in other builds so that RemoteSettings can use it in Android and TB.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1464006 - Move Normandy FilterExpressions to toolkit/components/utils

Review commit: https://reviewboard.mozilla.org/r/246366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246366/

Comment 2

[Mathieu Leplatre [:leplatrem]]

The Try builds fails on some completely unrelated jobs. I'd say we can ignore them.

Comment 3

[Michael Cooper [:mythmon]]

Comment on attachment 8980219 [details]
Bug 1464006 - Move Normandy FilterExpressions to toolkit/components/utils

https://reviewboard.mozilla.org/r/246366/#review252586

Besides a couple comments on the tests, this seems like a straight forward move. +1

::: toolkit/components/utils/test/unit/test_FilterExpressions.js:72
(Diff revision 1)
>  
>  // Preference tests
>  add_task(async function() {
>    let val;
>    // Compare the value of the preference
> -  await SpecialPowers.pushPrefEnv({set: [["normandy.test.value", 3]]});
> +  Services.prefs.setIntPref("normandy.test.value", 3);

`SpecialPowers.pushPrefEnv` takes care of resetting prefs after the test finishes. Is this no longer needed in xpcshell tests?

::: toolkit/components/utils/test/unit/test_Sampling.js:3
(Diff revision 1)
>  "use strict";
>  
> -ChromeUtils.import("resource://normandy/lib/Sampling.jsm", this);
> +ChromeUtils.defineModuleGetter(this, "Sampling", "resource://gre/modules/components-utils/Sampling.jsm");

I suspect this should stay as `ChromeUtils.import`. Is there a reason to change to a lazy import?

Comment 4

[Mathieu Leplatre [:leplatrem]]

Comment on attachment 8980219 [details]
Bug 1464006 - Move Normandy FilterExpressions to toolkit/components/utils

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246366/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d51f23418197
Move Normandy FilterExpressions to toolkit/components/utils r=mythmon

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d51f23418197