1464127 - Disable downgrade checks

Status: RESOLVED FIXED

(Testing :: mozregression, task, P1)

Description

[Dave Townsend [:mossop]]

Bug 1455707 is going to start complaining if the profile is being run with a downgraded version of Firefox. There is a command line option to bypass this and mozregression should probably pass this in certain cases, maybe just all the time.

--allow-downgrade

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

I don't think it's reasonable to call this an enhancement at this point; mozregression doesn't work across downgraded versions anymore.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

https://github.com/mozilla/mozregression/pull/534

Comment 4

[Dave Townsend [:mossop]]

I'd be interested to know what cases exists that weren't already fixed by https://github.com/mozilla/mozregression/pull/510

Comment 5

[William Lachance (:wlach)]

(In reply to Dave Townsend [:mossop] (he/him) from comment #4)

I'd be interested to know what cases exists that weren't already fixed by https://github.com/mozilla/mozregression/pull/510

If there's an alternate way of solving this bug, please let me know! I would prefer not to pass args in mozregression. For now, I've merged Aaron's pr (with some minor modifications) and will do up a new release shortly.

Comment 6

[Dave Townsend [:mossop]]

What I was saying is that https://github.com/mozilla/mozregression/pull/510 was already making mozregression pass --allow-downgrade arguments to Firefox in what I thought were the necessary cases. Just wondering what cases it missed. If https://github.com/mozilla/mozregression/pull/534 is making us always pass --allow-downgrade to Firefox then https://github.com/mozilla/mozregression/pull/510 is probably no longer necessary.

Comment 7

[William Lachance (:wlach)]

(In reply to Dave Townsend [:mossop] (he/him) from comment #6)

What I was saying is that https://github.com/mozilla/mozregression/pull/510 was already making mozregression pass --allow-downgrade arguments to Firefox in what I thought were the necessary cases. Just wondering what cases it missed. If https://github.com/mozilla/mozregression/pull/534 is making us always pass --allow-downgrade to Firefox then https://github.com/mozilla/mozregression/pull/510 is probably no longer necessary.

Geez, yeah, that does look like it's trying to do the same thing! I should have grepped through the codebase before landing the latest PR, my recollection was that the earlier changes to make this work were just around preferences.

I didn't test, but I suspect the approach in #510 might fail if you're passing a URL to the application. That was certainly a problem with #534 until I made some adjustments. I think the solution there is a little more robust, so I'll look into reverting #510 in a bit.

Comment 8

[Ian Moody [:Kwan] (UTC+0)]

Attachment: [GitHub PR] Bypass profile downgrade detection when using the same profile for bisection.

Comment 9

[Ian Moody [:Kwan] (UTC+0)]

Attachment: [GitHub PR] Make FirefoxLauncher always add --allow-downgrade to cmdargs

Comment 11

[Ian Moody [:Kwan] (UTC+0)]

Based on bug 1550806 comment 3 it looks like I was too quick to assume what the problem was and dupe. I think we should actually revert PR#534 seeing as it didn't help with what it was meant to (and might have actually broken URL passing, for me at least).