1464162 - Make a few vector operations more efficient by reserving size beforehand.

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Jan Keromnes [:janx]]

These automated fixes were generated like so:

    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *

Comment 1

[Phabricator Automation]

Attachment: Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

These automated fixes were generated like so:
    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8980379 [details]
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

I'm not the right person to review this.
:drno can better direct you

Comment 3

[Jean-Yves Avenard [:jya]]

on 2nd thought, they do make sense, so I'll accept it.

Comment 4

[Phabricator Automation]

Comment on attachment 8980379 [details]
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

Jean-Yves Avenard [:jya] has approved the revision.

https://phabricator.services.mozilla.com/D1381

Comment 5

[Jan Keromnes [:janx]]

Cool, thanks!

Comment 6

[Jean-Yves Avenard [:jya]]

you haven't addressed my comment (or I don't know how to use phabricator properly)

Comment 7

[Jan Keromnes [:janx]]

(In reply to Jean-Yves Avenard [:jya] from comment #6)
> you haven't addressed my comment (or I don't know how to use phabricator
> properly)

Oops, indeed! Thanks for being watchful. I assumed your comments would be copied to Bugzilla as with MozReview. I'll address them shortly.

Comment 8

[Jan Keromnes [:janx]]

Nits addressed, except the one about the pre-existing ugly const_cast. Please let me know if you'd like me to change it in some way, otherwise let's merge this patch.

Comment 9

[Jan Keromnes [:janx]]

Try push for good measure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76076f38370919e570963c31beabe04e5cde9a24

Comment 10

[Jan Keromnes [:janx]]

All green! Go for launch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0c658fae24c
Make a few vector operations more efficient by reserving size beforehand. r=jya

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a0c658fae24c