Make a few vector operations more efficient by reserving size beforehand.

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
Rank:
25
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: janx, Assigned: janx)

Tracking

unspecified
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
These automated fixes were generated like so:

    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *
These automated fixes were generated like so:
    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *
(Assignee)

Updated

11 months ago
Attachment #8980379 - Flags: review?(jyavenard)
Comment on attachment 8980379 [details]
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

I'm not the right person to review this.
:drno can better direct you
Flags: needinfo?(drno)
Attachment #8980379 - Flags: review?(jyavenard)
on 2nd thought, they do make sense, so I'll accept it.
Flags: needinfo?(drno)
Comment on attachment 8980379 [details]
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

Jean-Yves Avenard [:jya] has approved the revision.

https://phabricator.services.mozilla.com/D1381
Attachment #8980379 - Flags: review+
(Assignee)

Comment 5

11 months ago
Cool, thanks!
Keywords: checkin-needed
you haven't addressed my comment (or I don't know how to use phabricator properly)
Keywords: checkin-needed
Component: Audio/Video → WebRTC: Signaling
(Assignee)

Comment 7

11 months ago
(In reply to Jean-Yves Avenard [:jya] from comment #6)
> you haven't addressed my comment (or I don't know how to use phabricator
> properly)

Oops, indeed! Thanks for being watchful. I assumed your comments would be copied to Bugzilla as with MozReview. I'll address them shortly.
(Assignee)

Comment 8

11 months ago
Nits addressed, except the one about the pre-existing ugly const_cast. Please let me know if you'd like me to change it in some way, otherwise let's merge this patch.
Flags: needinfo?(jyavenard)

Updated

11 months ago
Rank: 25
Priority: -- → P3
(Assignee)

Comment 10

11 months ago
All green! Go for launch.
Keywords: checkin-needed

Comment 11

11 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0c658fae24c
Make a few vector operations more efficient by reserving size beforehand. r=jya
Keywords: checkin-needed

Comment 12

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a0c658fae24c
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: needinfo?(jyavenard)
You need to log in before you can comment on or make changes to this bug.