Open Bug 1464237 Opened 6 years ago Updated 2 years ago

[wpt-sync] Sync PR 11151 - Fix accessing serviceworker tests for .https.any.js files.

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11151 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/11151
Details from upstream follow.

James Graham <james@hoppipolla.co.uk> wrote:
>  Fix accessing serviceworker tests for .https.any.js files.
>  
>  Our support for autogenerated wrappers in any.js files assumes that
>  there's a 1:1 mapping between the incoming URL and the underlying js
>  file on the fielsystem. This is nearly true, but because we force
>  serviceworker tests to run via https, foo.any.js and foo.https.any.js
>  generate the same serviceworker test url. "Fixing" this by doubling
>  the https in the latter case (i.e. making the test url
>  foo.https.https.serviceworker.any.html) is bad because it violates the
>  assumption that .https. is a flag. Instead, this commit adds a hacky
>  solution where we first look for foo.any.js and if that doesn't
>  succeed we then look for foo.https.any.js, if the url suffix starts
>  with .https. This is fine as long as no one adds foo.any.js and
>  foo.https.any.js expecting them to do different things.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.