1464244 - Images in suspended background tabs will flicker/blink/flash after landing patches from bug #1176019 {browser.tabs.remote.tabCacheSize: 5}

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

1. Open some website page with many images
2. Open other tabs and browse it for some time,
so background tab with website page with images will suspended after some time
3. Go back to website page with many images
and see that images will flicker/blink/flash like they're rerendered/redownloaded

Comment 1

[Alice0775 White]

Could you please provide a sample page of step1 and step2?
How long should I stay in the tab in step2?

Comment 2

[Alice0775 White]

STR:
1. Open https://www.instagram.com/nana_eikura/ (no need loggin)
   Or about:home if you have Highlight thumbnails
   Or any other page with images
2. Open a New Tab in foreground tab
3. Wait for 2 minutes at least
4. Switch back to the tab of step1


Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e5ef53eee5b69f9be604029afa46ba0afb75966&tochange=9c10d9a7198331b7a650cef79ed37f36d23a2c88

Regressed by: Bug 1176019

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Thank you very much Alice0775 White for finding specific regression range.

Comment 4

[Alex Thayer [:alexical] (she/her)]

I can only seem to reproduce this on OSX - not on Windows. Just to confirm, Alice0775 what OS are you seeing this on?

Comment 5

[Alice0775 White]

(In reply to Doug Thayer [:dthayer] (PTO on May 17) from comment #4)
> I can only seem to reproduce this on OSX - not on Windows. Just to confirm,
> Alice0775 what OS are you seeing this on?

Win10 Home 64bit version 1803

Comment 6

[Mike Taylor [:miketaylr]]

Hey Doug, is this something you want to take? Not sure how critical this is. Thanks!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

The LRU cache was disabled in bug 1465106, and should be disabled in today's Nightly. Virtual_ManPL, are you still seeing this?

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Hmm, oddly, I can still reproduce this issue with Mozilla Firefox Nightly 62.0a1 (2018-05-30) (64-bit) on Windows 7 (64-bit) [ https://hg.mozilla.org/mozilla-central/rev/5866d6685849311f057e7e229b9ace63a2641c29 ].

@  Alice0775 White - Could you please retest it too and report back your results?

Comment 9

[Alice0775 White]

I can manage to reproduce the flickering on Win10 Nightly62.0a1 x64(20180529095249).
But, I can no longer reproduce on Win10 Nightly62.0a1 x64(20180530100110).
Of course, I can reproduce the issue on Nightly62.0a1 x64(20180530100110) if set browser.tabs.remote.tabCacheSize to 5.

Comment 10

[Alex Thayer [:alexical] (she/her)]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #8)
> Hmm, oddly, I can still reproduce this issue with Mozilla Firefox Nightly
> 62.0a1 (2018-05-30) (64-bit) on Windows 7 (64-bit) [
> https://hg.mozilla.org/mozilla-central/rev/
> 5866d6685849311f057e7e229b9ace63a2641c29 ].

Can you reproduce this if you switch tabs with ctrl+tab instead of clicking on them? I'm wondering if the 1176019 had some kind of side effect on tab warming.

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Doug Thayer [:dthayer] (PTO on June 4) from comment #10)
> (In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see
> your comment/reply/question/etc.) from comment #8)
> > Hmm, oddly, I can still reproduce this issue with Mozilla Firefox Nightly
> > 62.0a1 (2018-05-30) (64-bit) on Windows 7 (64-bit) [
> > https://hg.mozilla.org/mozilla-central/rev/
> > 5866d6685849311f057e7e229b9ace63a2641c29 ].
> 
> Can you reproduce this if you switch tabs with ctrl+tab instead of clicking
> on them? I'm wondering if the 1176019 had some kind of side effect on tab
> warming.

Yes, I can reproduce it now only if I will use Ctrl+Tab, clicking work fine. I will look on it deeper in next week.

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #11)
> (In reply to Doug Thayer [:dthayer] (PTO on June 4) from comment #10)
> > (In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see
> > your comment/reply/question/etc.) from comment #8)
> > > Hmm, oddly, I can still reproduce this issue with Mozilla Firefox Nightly
> > > 62.0a1 (2018-05-30) (64-bit) on Windows 7 (64-bit) [
> > > https://hg.mozilla.org/mozilla-central/rev/
> > > 5866d6685849311f057e7e229b9ace63a2641c29 ].
> > 
> > Can you reproduce this if you switch tabs with ctrl+tab instead of clicking
> > on them? I'm wondering if the 1176019 had some kind of side effect on tab
> > warming.
> 
> Yes, I can reproduce it now only if I will use Ctrl+Tab, clicking work fine.
> I will look on it deeper in next week.

Hmm, after some time and minimizing windows, it's also reproducible on clicking.

Comment 13

[Mike Taylor [:miketaylr]]

Setting to disable due to Bug 1465106.

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

It's still reproducible in some way for me, so I'm marking Firefox 62 as affected.

Comment 15

[Mike Taylor [:miketaylr]]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #14)
> It's still reproducible in some way for me, so I'm marking Firefox 62 as
> affected.

In what way? if it's with browser.tabs.remote.tabCacheSize set to 5, please set back to disabled. That won't ride to release yet.

Comment 16

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I didn't change "browser.tabs.remote.tabCacheSize" preference value and have it set as "0".

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Hey dthayer - are you able to reproduce this at all on macOS with the cache set to 0?

We might want to consider just backing out the cache patch, since it's intended functionality is effectively disabled for now.

Comment 18

[Alex Thayer [:alexical] (she/her)]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos / reviews) from comment #17)
> Hey dthayer - are you able to reproduce this at all on macOS with the cache
> set to 0?
> 
> We might want to consider just backing out the cache patch, since it's
> intended functionality is effectively disabled for now.

Yeah we can do that - I do first just want to try disabling one bit of code to check if this is responsible. I can't reproduce though, so Virtual, can you reproduce the problem with the following build?

https://queue.taskcluster.net/v1/task/O2yEsDJQR66UCoQNg23eWA/runs/0/artifacts/public/build/target.zip

Comment 19

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Doug Thayer [:dthayer] (PTO on June 4) from comment #18)
> (In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos /
> reviews) from comment #17)
> > Hey dthayer - are you able to reproduce this at all on macOS with the cache
> > set to 0?
> > 
> > We might want to consider just backing out the cache patch, since it's
> > intended functionality is effectively disabled for now.
> 
> Yeah we can do that - I do first just want to try disabling one bit of code
> to check if this is responsible. I can't reproduce though, so Virtual, can
> you reproduce the problem with the following build?
> 
> https://queue.taskcluster.net/v1/task/O2yEsDJQR66UCoQNg23eWA/runs/0/
> artifacts/public/build/target.zip

It's also reproducible with this build,
but I'm very sorry, Alice0775 White was right,
main bug isn't reproducible anymore and was like:
-no image
-image loads
-image reloads
now it only stayed:
-no image
-image loads
which wasn't caused by patches from bug #1176019,
but I will try to find cause of that issue too and report it in new created bug.
Thank you very much for your attention!