1464265 - Split console close button should use fill: var(--theme-toolbar-photon-icon-color)

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Brian Birtles (:birtles)]

Attachment: Screenshot

In the light theme, the color of the two close buttons are different and it looks odd.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Thanks! Brian.

I didn't apply the photon icon color fill. We need to apply the photon icon color fill the sidebar of webconsole as well.

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1464265 - Apply photon icon fill to close button of webconsole.

Webconsole has two close buttons. (split console and sidebar)
This patch will apply photon icon color fill to these buttons.

Review commit: https://reviewboard.mozilla.org/r/246634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246634/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

https://reviewboard.mozilla.org/r/246634/#review252794

Tested in light and dark mode and looks good. Thanks Mantaroh !

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

https://reviewboard.mozilla.org/r/246634/#review252794

Thanks you for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed795ab22fe5
Apply photon icon fill to close button of webconsole. r=nchevobbe

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ed795ab22fe5

Comment 7

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

Approval Request Comment
[Feature/Bug causing the regression]:bug 1444302
[User impact if declined]: The close button of a split console is not consistency.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: bug 1444302
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is only the change of styles.
[String changes made/needed]: N/A

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

CSS fix needed to support bug 1444302. Approved for 61.0b10.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbd8df4584c4