Split console close button should use fill: var(--theme-toolbar-photon-icon-color)

RESOLVED FIXED in Firefox 61

Status

defect
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: birtles, Assigned: mantaroh)

Tracking

unspecified
Firefox 62
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox61 fixed, firefox62 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 months ago
Posted image Screenshot
In the light theme, the color of the two close buttons are different and it looks odd.
(Assignee)

Comment 1

11 months ago
Thanks! Brian.

I didn't apply the photon icon color fill. We need to apply the photon icon color fill the sidebar of webconsole as well.
Assignee: nobody → mantaroh
Comment hidden (mozreview-request)
Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

https://reviewboard.mozilla.org/r/246634/#review252794

Tested in light and dark mode and looks good. Thanks Mantaroh !
Attachment #8980469 - Flags: review?(nchevobbe) → review+
(Assignee)

Comment 4

11 months ago
mozreview-review-reply
Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

https://reviewboard.mozilla.org/r/246634/#review252794

Thanks you for the review!

Comment 5

11 months ago
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ed795ab22fe5
Apply photon icon fill to close button of webconsole. r=nchevobbe

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ed795ab22fe5
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
(Assignee)

Comment 7

11 months ago
Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

Approval Request Comment
[Feature/Bug causing the regression]:bug 1444302
[User impact if declined]: The close button of a split console is not consistency.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: bug 1444302
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is only the change of styles.
[String changes made/needed]: N/A
Attachment #8980469 - Flags: approval-mozilla-beta?
Comment on attachment 8980469 [details]
Bug 1464265 - Apply photon icon fill to close button of webconsole.

CSS fix needed to support bug 1444302. Approved for 61.0b10.
Attachment #8980469 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.