1464328 - Autofill to-the-next-slash is broken

Status: VERIFIED FIXED

(Toolkit :: Places, defect, P1)

Description

[Marco Bonardo [:mak]]

Autofill used to complete up to the next slash, that seems to be broken now.
For example reddit.com/r/firefox/ should be autofilled as
reddit.com/
reddit.com/r/
reddit.com/r/firefox/

while now it's filled as
reddit.com/
reddit.com/r/firefox/

Comment 1

[Marco Bonardo [:mak]]

Note, we may decide this is better than it was, since now the algorithm is based on frecency and not based on a loose value.
This bug is to discuss and decide what's the new expected behavior.

Comment 2

[Marco Bonardo [:mak]]

This is likely caused by bug 1463580 and thus could be fixed by the same patch.

I'm thinking we should restore this, even just to preserve muscle memory, because we don't have a clear indication of the benefits compared to the downsides.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Marco Bonardo [::mak] from comment #2)
> This is likely caused by bug 1463580 and thus could be fixed by the same
> patch.

Only partially true, this will still need code and tests to be re-added into matchKnownUrl to handle trimming the result to the next slash.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1464328 - Autofill urls to-the-next-slash is broken.

Review commit: https://reviewboard.mozilla.org/r/247622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247622/

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8981492 [details]
Bug 1464328 - Autofill urls to-the-next-slash is broken.

Merging this patch into bug 1463580

Comment 6

[Marco Bonardo [:mak]]

Fixed by bug 1463580.

Comment 7

[u554753]

Verified on the yesterday's Nightly (62.0a1) 06-07-2018 with the following OS: Windows 10 x64, Mac OSX 10.11, and Ubuntu 18.10 x64
Version: 62.0a1
Build ID: 20180607100059

Per Bug 1463580.