1464400 - Add a CSSGeneric attribute to InspectorFontFace

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Jonathan Kew [:jfkthame]]

It would be useful for the DevTools font inspector to be able to show when a particular font face was the result of resolving a CSS generic font-family value (serif, sans-serif, etc) rather than the family being explicitly named in the font-family list.

The effective mapping from CSS generics to font families is dependent on the lang of the element, the current settings of font.name-list.<generic>.<lang> prefs, the font whitelist in effect (if any), and the fonts actually present on the system, so it would be pretty hard for devtools to implement some kind of reverse-mapping from the font faces actually used to the generics found in the font-family property. But I think we can fairly easily keep track of generics through the font-matching process so that when getUsedFontFaces reports the fonts used in a range, it can include a CSSGeneric attribute on any faces that were the result of resolving a generic family name.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8dbb1d2d07c
Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace. r=jwatt

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f8dbb1d2d07c (bug 1464400) for mochitest failures on test_font_whitelist.html

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/538a689e3487689416f0c06630a19cbc4ab193f7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f8dbb1d2d07cb5645d8370b1f766b21da538d392&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&selectedJob=181367308

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=181367308&repo=mozilla-inbound&lineNumber=1596

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eabcc7a5eae
Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace. r=jwatt

Comment 5

[Jonathan Kew [:jfkthame]]

Re-landed this, as the real culprit was the other patch in the same push (bug 1463115).

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9eabcc7a5eae