Closed Bug 1464481 Opened 6 years ago Closed 6 years ago

WebRequest securityInfo crash when used without blocking listeners

Categories

(WebExtensions :: Request Handling, defect, P1)

58 Branch
defect

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

Attachments

(1 file)

This is a followup patch to bug 1322748.

The tests only covered blocking requests :(

Thanks evilpie for finding that!
Flags: qe-verify-
Essentially, when we use non-blocking listeners only the channel register never happens.  The crash would happen when attempting to get the registered channel.
Assignee: nobody → mixedpuppy
Priority: -- → P1
Comment on attachment 8980687 [details]
Bug 1464481 - fix and test crash when getting registered channelwrapper,

https://reviewboard.mozilla.org/r/246856/#review253022
Attachment #8980687 - Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7427913e4eda
fix and test crash when getting registered channelwrapper, r=kmag
https://hg.mozilla.org/mozilla-central/rev/7427913e4eda
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Keywords: dev-doc-needed
Keywords: dev-doc-needed
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: