Closed
Bug 1464656
Opened 7 years ago
Closed 7 years ago
Enable WebAssembly.Global by default
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jseward, Assigned: jseward)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
78.71 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
WebAssembly.Global is currently nightly- and early-beta-only, gated by
ENABLE_WASM_GLOBAL and EARLY_BETA_OR_EARLIER respectively. This bug is to
enable it by default.
Assignee | ||
Comment 1•7 years ago
|
||
I think I got everything (famous last words, etc).
Assignee | ||
Updated•7 years ago
|
Attachment #8980971 -
Flags: feedback?(lhansen)
Assignee | ||
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8980971 [details] [diff] [review]
First attempt
Review of attachment 8980971 [details] [diff] [review]:
-----------------------------------------------------------------
Good to go, as far as I'm concerned.
::: js/src/jit-test/tests/wasm/spec/harness/index.js
@@ +224,5 @@
> if (instance.isError())
> return instance;
>
> // Experimental API change. We try to export WebAssembly.Global instances,
> // not primitive values. In that case the Number() cast is necessary here
At least "Experimental API change" could be removed here but the comment block should probably be reworked to just explain what's going on.
Attachment #8980971 -
Flags: feedback?(lhansen) → review+
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91a5de2fb8ca
Enable WebAssembly.Global by default. r=lth.
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee | ||
Updated•7 years ago
|
Keywords: dev-doc-needed
Updated•7 years ago
|
Assignee: nobody → jseward
Comment 6•6 years ago
|
||
WebAssembly.Global() has been documented:
* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Global
* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Global/prototype
* https://developer.mozilla.org/en-US/docs/WebAssembly/Understanding_the_text_format#Declaring_globals_in_WebAssembly
* https://developer.mozilla.org/en-US/docs/WebAssembly/Using_the_JavaScript_API#Globals
* https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/62#JavaScript
Lars T Hansen has reviewed it, so I think we are good to go.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•