Closed Bug 1464656 Opened 2 years ago Closed 2 years ago

Enable WebAssembly.Global by default

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jseward, Assigned: jseward)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

WebAssembly.Global is currently nightly- and early-beta-only, gated by
ENABLE_WASM_GLOBAL and EARLY_BETA_OR_EARLIER respectively.  This bug is to
enable it by default.
Attached patch First attemptSplinter Review
I think I got everything (famous last words, etc).
Attachment #8980971 - Flags: feedback?(lhansen)
Comment on attachment 8980971 [details] [diff] [review]
First attempt

Review of attachment 8980971 [details] [diff] [review]:
-----------------------------------------------------------------

Good to go, as far as I'm concerned.

::: js/src/jit-test/tests/wasm/spec/harness/index.js
@@ +224,5 @@
>      if (instance.isError())
>          return instance;
>  
>      // Experimental API change.  We try to export WebAssembly.Global instances,
>      // not primitive values.  In that case the Number() cast is necessary here

At least "Experimental API change" could be removed here but the comment block should probably be reworked to just explain what's going on.
Attachment #8980971 - Flags: feedback?(lhansen) → review+
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91a5de2fb8ca
Enable WebAssembly.Global by default.  r=lth.
https://hg.mozilla.org/mozilla-central/rev/91a5de2fb8ca
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Keywords: dev-doc-needed
Assignee: nobody → jseward
You need to log in before you can comment on or make changes to this bug.