1464656 - Enable WebAssembly.Global by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Julian Seward [:jseward]]

WebAssembly.Global is currently nightly- and early-beta-only, gated by
ENABLE_WASM_GLOBAL and EARLY_BETA_OR_EARLIER respectively.  This bug is to
enable it by default.

Comment 1

[Julian Seward [:jseward]]

Attachment: First attempt

I think I got everything (famous last words, etc).

Comment 2

[Julian Seward [:jseward]]

Looks OK on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ba61354a13bdeb166254262acaa68b9476d6e2d

Comment 3

[Lars T Hansen [:lth]]

Comment on attachment 8980971 [details] [diff] [review]
First attempt

Review of attachment 8980971 [details] [diff] [review]:
-----------------------------------------------------------------

Good to go, as far as I'm concerned.

::: js/src/jit-test/tests/wasm/spec/harness/index.js
@@ +224,5 @@
>      if (instance.isError())
>          return instance;
>  
>      // Experimental API change.  We try to export WebAssembly.Global instances,
>      // not primitive values.  In that case the Number() cast is necessary here

At least "Experimental API change" could be removed here but the comment block should probably be reworked to just explain what's going on.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91a5de2fb8ca
Enable WebAssembly.Global by default.  r=lth.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/91a5de2fb8ca

Comment 6

[Chris Mills [:cmills]]

WebAssembly.Global() has been documented:

* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Global
* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Global/prototype
* https://developer.mozilla.org/en-US/docs/WebAssembly/Understanding_the_text_format#Declaring_globals_in_WebAssembly
* https://developer.mozilla.org/en-US/docs/WebAssembly/Using_the_JavaScript_API#Globals
* https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/62#JavaScript

Lars T Hansen has reviewed it, so I think we are good to go.