Closed Bug 1464722 Opened Last year Closed Last year

Implement scrollbar color properties for cocoa widget

Categories

(Core :: Widget: Cocoa, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(8 files)

No description provided.
Summary: Implement scrollbar color properties on cocoa widget → Implement scrollbar color properties for cocoa widget
Priority: -- → P3
Assignee: nobody → xidorn+moz
This is a screenshot showing what it looks like with scrollbar colors used on macOS with this patchset.
Comment on attachment 8987391 [details]
Bug 1464722 part 2 - Move relative luminance functions into gfx.

https://reviewboard.mozilla.org/r/252628/#review259262
Attachment #8987391 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8987392 [details]
Bug 1464722 part 3 - Fix rtl computation in ComputeScrollbarParams.

https://reviewboard.mozilla.org/r/252630/#review259714
Attachment #8987392 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8987395 [details]
Bug 1464722 part 6 - Enable scrollbar colors test on mac.

https://reviewboard.mozilla.org/r/252636/#review259730
Attachment #8987395 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8987393 [details]
Bug 1464722 part 4 - Render custom scrollbars on cocoa widget.

https://reviewboard.mozilla.org/r/252632/#review259732
Attachment #8987393 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8987394 [details]
Bug 1464722 part 5 - Paint scrollcorner for custom scrollbars on cocoa.

https://reviewboard.mozilla.org/r/252634/#review259734
Attachment #8987394 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8987390 [details]
Bug 1464722 part 1 - Move functions related to custom scrollbars into nsNativeTheme.

https://reviewboard.mozilla.org/r/252626/#review260040
Attachment #8987390 - Flags: review?(jmathies) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/199da6ff2b79
part 1 - Move functions related to custom scrollbars into nsNativeTheme. r=jimm
https://hg.mozilla.org/integration/autoland/rev/e7b2196c6858
part 2 - Move relative luminance functions into gfx. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cea8532fd3f4
part 3 - Fix rtl computation in ComputeScrollbarParams. r=spohl
https://hg.mozilla.org/integration/autoland/rev/664fc5136a49
part 4 - Render custom scrollbars on cocoa widget. r=spohl
https://hg.mozilla.org/integration/autoland/rev/a8b609fb90ad
part 5 - Paint scrollcorner for custom scrollbars on cocoa. r=spohl
https://hg.mozilla.org/integration/autoland/rev/479c0a3c61fd
part 6 - Enable scrollbar colors test on mac. r=spohl
Depends on: 1471766
Depends on: 1471866
Let's give this time on Nightly. Xidorn, is this intended for 63 or is there any need to uplift for 62?
Flags: needinfo?(xidorn+moz)
No need to uplift.
Flags: needinfo?(xidorn+moz)
You need to log in before you can comment on or make changes to this bug.