1464722 - Implement scrollbar color properties for cocoa widget

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1464722 part 1 - Move functions related to custom scrollbars into nsNativeTheme.

Review commit: https://reviewboard.mozilla.org/r/252626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252626/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1464722 part 2 - Move relative luminance functions into gfx.

Review commit: https://reviewboard.mozilla.org/r/252628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252628/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1464722 part 3 - Fix rtl computation in ComputeScrollbarParams.

Review commit: https://reviewboard.mozilla.org/r/252630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252630/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1464722 part 4 - Render custom scrollbars on cocoa widget.

Review commit: https://reviewboard.mozilla.org/r/252632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252632/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1464722 part 5 - Paint scrollcorner for custom scrollbars on cocoa.

Review commit: https://reviewboard.mozilla.org/r/252634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252634/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1464722 part 6 - Enable scrollbar colors test on mac.

Review commit: https://reviewboard.mozilla.org/r/252636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252636/

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Attachment: screenshot with scrollbar colors

This is a screenshot showing what it looks like with scrollbar colors used on macOS with this patchset.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Attachment: another screenshot using colors from Twitter dark mode

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8987391 [details]
Bug 1464722 part 2 - Move relative luminance functions into gfx.

https://reviewboard.mozilla.org/r/252628/#review259262

Comment 10

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Comment on attachment 8987392 [details]
Bug 1464722 part 3 - Fix rtl computation in ComputeScrollbarParams.

https://reviewboard.mozilla.org/r/252630/#review259714

Comment 11

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Comment on attachment 8987395 [details]
Bug 1464722 part 6 - Enable scrollbar colors test on mac.

https://reviewboard.mozilla.org/r/252636/#review259730

Comment 12

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Comment on attachment 8987393 [details]
Bug 1464722 part 4 - Render custom scrollbars on cocoa widget.

https://reviewboard.mozilla.org/r/252632/#review259732

Comment 13

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Comment on attachment 8987394 [details]
Bug 1464722 part 5 - Paint scrollcorner for custom scrollbars on cocoa.

https://reviewboard.mozilla.org/r/252634/#review259734

Comment 14

[Jim Mathies [:jimm]]

Comment on attachment 8987390 [details]
Bug 1464722 part 1 - Move functions related to custom scrollbars into nsNativeTheme.

https://reviewboard.mozilla.org/r/252626/#review260040

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/199da6ff2b79
part 1 - Move functions related to custom scrollbars into nsNativeTheme. r=jimm
https://hg.mozilla.org/integration/autoland/rev/e7b2196c6858
part 2 - Move relative luminance functions into gfx. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cea8532fd3f4
part 3 - Fix rtl computation in ComputeScrollbarParams. r=spohl
https://hg.mozilla.org/integration/autoland/rev/664fc5136a49
part 4 - Render custom scrollbars on cocoa widget. r=spohl
https://hg.mozilla.org/integration/autoland/rev/a8b609fb90ad
part 5 - Paint scrollcorner for custom scrollbars on cocoa. r=spohl
https://hg.mozilla.org/integration/autoland/rev/479c0a3c61fd
part 6 - Enable scrollbar colors test on mac. r=spohl

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/199da6ff2b79
https://hg.mozilla.org/mozilla-central/rev/e7b2196c6858
https://hg.mozilla.org/mozilla-central/rev/cea8532fd3f4
https://hg.mozilla.org/mozilla-central/rev/664fc5136a49
https://hg.mozilla.org/mozilla-central/rev/a8b609fb90ad
https://hg.mozilla.org/mozilla-central/rev/479c0a3c61fd

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Let's give this time on Nightly. Xidorn, is this intended for 63 or is there any need to uplift for 62?

Comment 18

[Xidorn Quan [:xidorn] UTC+10]

No need to uplift.