Closed Bug 1464737 Opened Last year Closed Last year

Simplify nsDisplayPerspective

Categories

(Core :: Web Painting, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

Current we set mFrame to the perspective frame, and hold the transform frame as an extra pointer.

We have to track an extra index to use in GetPerFrameKey, since we can have multiple transformed frames for each perspective. This index counting increments for each item built, so we can't support partial display list builds.

We also have to add extra tracking for the transformed frame, since it can be deleted without invalidating the perspective frame.

It would be simpler to just use the transform frame as mFrame, and manually setup the AGR to be what we want.
Assignee: nobody → matt.woodrow
Priority: -- → P3
Comment on attachment 8981040 [details]
Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame.

https://reviewboard.mozilla.org/r/247156/#review254550

LGTM.
Attachment #8981040 - Flags: review?(mikokm) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 24482d98b73f1e14f7da3ddacb45f1b4a62831d5 -d 996ab33915e7: rebasing 466380:24482d98b73f "Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame. r=miko" (tip)
merging layout/generic/nsFrame.cpp
merging layout/painting/FrameLayerBuilder.cpp
merging layout/painting/nsDisplayList.cpp
merging layout/painting/nsDisplayList.h
warning: conflicts while merging layout/painting/nsDisplayList.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b1bd397ecad
Make nsDisplayPerspective simpler by using the transform frame as mFrame. r=miko
https://hg.mozilla.org/mozilla-central/rev/7b1bd397ecad
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Blocks: 1464749
You need to log in before you can comment on or make changes to this bug.