1464737 - Simplify nsDisplayPerspective

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Current we set mFrame to the perspective frame, and hold the transform frame as an extra pointer.

We have to track an extra index to use in GetPerFrameKey, since we can have multiple transformed frames for each perspective. This index counting increments for each item built, so we can't support partial display list builds.

We also have to add extra tracking for the transformed frame, since it can be deleted without invalidating the perspective frame.

It would be simpler to just use the transform frame as mFrame, and manually setup the AGR to be what we want.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame.

Review commit: https://reviewboard.mozilla.org/r/247156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247156/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8981040 [details]
Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247156/diff/1-2/

Comment 3

[Miko Mynttinen]

Comment on attachment 8981040 [details]
Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame.

https://reviewboard.mozilla.org/r/247156/#review254550

LGTM.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 24482d98b73f1e14f7da3ddacb45f1b4a62831d5 -d 996ab33915e7: rebasing 466380:24482d98b73f "Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame. r=miko" (tip)
merging layout/generic/nsFrame.cpp
merging layout/painting/FrameLayerBuilder.cpp
merging layout/painting/nsDisplayList.cpp
merging layout/painting/nsDisplayList.h
warning: conflicts while merging layout/painting/nsDisplayList.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8981040 [details]
Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247156/diff/2-3/

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8981040 [details]
Bug 1464737 - Make nsDisplayPerspective simpler by using the transform frame as mFrame.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247156/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b1bd397ecad
Make nsDisplayPerspective simpler by using the transform frame as mFrame. r=miko

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7b1bd397ecad