Closed Bug 1464754 Opened 2 years ago Closed 2 years ago

Use proper atomicops for ppc32/ppc64 in ipc/chromium

Categories

(Core :: IPC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: spectre, Assigned: spectre)

References

Details

Attachments

(1 file, 1 obsolete file)

Chromium IPC already appears to have atomicops for PowerPC, but the code as written doesn't use them. Furthermore, on ppc64, the fallback mutex code doesn't actually seem to link on this system, which is solved by enabling the atomicops for both (and is better anyway).
Since ARCH_CPU_PPC_FAMILY already exists, we'll just use that (it should have been specified already anyway).

Andrew, please advise if you are not an appropriate reviewer, but you seem to have touched this code last.
Assignee: nobody → spectre
Status: NEW → ASSIGNED
Attachment #8981062 - Flags: review?(continuation)
Fixed context lines, sorry.
Attachment #8981062 - Attachment is obsolete: true
Attachment #8981062 - Flags: review?(continuation)
Attachment #8981188 - Flags: review?(continuation)
Comment on attachment 8981188 [details] [diff] [review]
Use proper atomicops for ppc32/ppc64

Review of attachment 8981188 [details] [diff] [review]:
-----------------------------------------------------------------

Nathan is more likely than me to be able to give a good review of this.
Attachment #8981188 - Flags: review?(continuation) → review?(nfroyd)
Comment on attachment 8981188 [details] [diff] [review]
Use proper atomicops for ppc32/ppc64

Review of attachment 8981188 [details] [diff] [review]:
-----------------------------------------------------------------

If it works for you, it works for me.  Thanks.
Attachment #8981188 - Flags: review?(nfroyd) → review+
Comment on attachment 8981188 [details] [diff] [review]
Use proper atomicops for ppc32/ppc64

Thank *you*!
Attachment #8981188 - Flags: checkin?
Note that this patch is NPOTB, if the lander wants to add that annotation somewhere.
Keywords: checkin-needed
Comment on attachment 8981188 [details] [diff] [review]
Use proper atomicops for ppc32/ppc64

Note that we use the checkin-needed keyword to denote that a patch needs to be checked in by somebody else.  Sorry for not setting it previously!
Attachment #8981188 - Flags: checkin?
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26434931b343
Use proper atomicops for ppc32/ppc64. r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/26434931b343
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Could you please backport this fix on firefox 60 esr? thanks
You need to log in before you can comment on or make changes to this bug.