1464758 - BigInt shouldn't get the legacy fallback behaviour in Object.prototype.toString

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Test case:
---
delete BigInt.prototype[Symbol.toStringTag];
assertEq(Object.prototype.toString.call(BigInt(0)), "[object Object]");
---

Expected: Test passes
Actual: Object.prototype.toString returns "[object BigInt]"

Comment 1

[Tom S. (please needinfo tschuster)]

I would suggest just changing the name in the JSClass field to "Object". Hopefully bug 1277799 is going to be fixed at some point.

Comment 2

[André Bargull [:anba]]

Ugh, I forgot about bug 1277801. In the mean time just remove [1] and [2], because that should be removed in any case.

[1] https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/src/builtin/Object.cpp#477-481
[2] https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/src/builtin/Object.cpp#541-544

Comment 3

[Robin Templeton [:terpri]]

Attachment: BigInt shouldn't get the legacy fallback behaviour in Object.prototype.toString.

Change BigInt's class name to "Object" so that the correct tag is used
when the @@toStringTag property is not a string. Remove special cases
for BigInt in GetBuiltinTagFast and GetBuiltinTagSlow.

Comment 4

[André Bargull [:anba]]

Comment on attachment 8981537 [details] [diff] [review]
BigInt shouldn't get the legacy fallback behaviour in Object.prototype.toString.

Review of attachment 8981537 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf6bdd122ad
BigInt shouldn't get the legacy fallback behaviour in Object.prototype.toString. r=anba

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fcf6bdd122ad