Closed
Bug 1464834
Opened 6 years ago
Closed 6 years ago
Remove dead Servo code.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
It's not part of the build.
Comment 1•6 years ago
|
||
Just leaving enough for style and tests to compile. Otherwise it's really confusing, specially when looking for webidl stuff, and can confuse contributors too. I prefer to keep the rest as is, since the rest I do sync (semi) manually.
Assignee | ||
Comment 2•6 years ago
|
||
Comment on attachment 8981155 [details] Bug 1464834: Remove dead servo code. r=xidorn Mozreview and splinter weren't happy about this. I basically left components/style + dependencies, ports/geckolib and tests/unit/style (which we don't run but should). If you prefer it in try form there it is. https://hg.mozilla.org/try/rev/bf2e325117b98c1a414ab444ebbe97e02e6159b9
Attachment #8981155 -
Flags: review?(xidorn+moz)
Comment 3•6 years ago
|
||
Comment on attachment 8981155 [details] Bug 1464834: Remove dead servo code. r=xidorn Xidorn Quan [:xidorn] UTC+10 has approved the revision. https://phabricator.services.mozilla.com/D1434
Attachment #8981155 -
Flags: review+
Comment 4•6 years ago
|
||
Comment on attachment 8981155 [details] Bug 1464834: Remove dead servo code. r=xidorn Reviewed in the phabricator.
Attachment #8981155 -
Flags: review?(xidorn+moz)
Comment 5•6 years ago
|
||
Comment on attachment 8981155 [details] Bug 1464834: Remove dead servo code. r=xidorn I can't log in to Phabricator at the moment, but r=me with some comments: * There are some dotfiles under servo/ (including .cargo/) that can be deleted too. (I think the important things from .hgignore / .gitignore are handled by the top level files but may be good to check.) * Is it worth keeping servo/tests/unit/malloc_size_of/? * I guess we are not currently running tidy. Is it worth keeping servo/python/tidy/ and filing a bug to have it hooked up to the top-level mach?
Attachment #8981155 -
Flags: review+
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #5) > Comment on attachment 8981155 [details] > Bug 1464834: Remove dead servo code. r=xidorn > > I can't log in to Phabricator at the moment, but r=me with some comments: > > * There are some dotfiles under servo/ (including .cargo/) that can be > deleted too. (I think the important things from .hgignore / .gitignore are > handled by the top level files but may be good to check.) Yeah, good point, got rid of them. > * Is it worth keeping servo/tests/unit/malloc_size_of/? We're not running them ATM, and they don't seem ultra-useful tests. I can keep them for now I suppose. > * I guess we are not currently running tidy. Is it worth keeping > servo/python/tidy/ and filing a bug to have it hooked up to the top-level > mach? tidy can be installed via pip now, so I'd say even if we want to run tidy we don't want to keep the source there.
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa010a5f187 Remove dead servo code. r=xidorn,heycam
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a31a23c372 Bring back servo/moz.build to fix the linting failure. r=me
Comment 9•6 years ago
|
||
Comment on attachment 8981155 [details] Bug 1464834: Remove dead servo code. r=xidorn Cameron McCormack (:heycam) has been removed from the revision. https://phabricator.services.mozilla.com/D1434
Attachment #8981155 -
Flags: review+
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8fa010a5f187 https://hg.mozilla.org/mozilla-central/rev/b6a31a23c372
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•