Closed Bug 1464931 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 11208 - Do not allow the empty string as a facingMode constraint value for MediaStreams.

Categories

(Core :: Audio/Video: MediaStreamGraph, enhancement, P4)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11208 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11208
Details from upstream follow.

Guido Urdaneta <guidou@chromium.org> wrote:
>  Do not allow the empty string as a facingMode constraint value for MediaStreams.
>  
>  The empty string is an invalid facingMode value that was being
>  interpreted to be equivalent to the internal facing-mode value of NONE.
>  
>  Bug: 814309
>  Change-Id: I260fbc41fd17a8bdcd1ca63baffe3bed14f3c4ab
>  Reviewed-on: https://chromium-review.googlesource.com/1072471
>  WPT-Export-Revision: 5be7937f3ee87da6ba1bee696be37f015a4e15e5
Component: web-platform-tests → Audio/Video: MediaStreamGraph
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1

New tests that have failures or other problems:
/mediacapture-streams/GUM-invalid-facing-mode.https.html
    Tests that setting an invalid facingMode constraint in getUserMedia fails: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0b51c8761de
[wpt PR 11208] - Do not allow the empty string as a facingMode constraint value for MediaStreams., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3399b738459f
[wpt PR 11208] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc9ddda80375
[wpt PR 11208] - Do not allow the empty string as a facingMode constraint value for MediaStreams., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/1135f049cd2b
[wpt PR 11208] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/fc9ddda80375
https://hg.mozilla.org/mozilla-central/rev/1135f049cd2b
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.