Closed Bug 1464983 Opened 2 years ago Closed 2 months ago

Change Java Profiler's interval from 10ms to 1ms?

Categories

(Core :: Gecko Profiler, enhancement, P2)

Unspecified
Android
enhancement

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox62 --- wontfix
firefox78 --- fixed

People

(Reporter: m_kato, Assigned: canova)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

When implementing JavaProfiler (bug 788022), interval's minimum is 10ms

Hardware is faster than 5 years ago, so we can change it.
Summary: Change Java Profiler's interval from 10ms to 1ms → Change Java Profiler's interval from 10ms to 1ms?
2ms on old phone (Galaxy Nexus / Android 4.3)
https://perfht.ml/2xtIvSL

1ms on old phone (Galaxy Nexus / Android 4.3)
https://perfht.ml/2J3hcQv

2ms on XPERIA Z3 / Android 6.0
https://perfht.ml/2xtWBUf

1ms on XPERIA Z3 / Android 6.0
https://perfht.ml/2J0pV68

1ms is unstable for resolution.  But I might try newSingleThreadScheduledExecutor instead of Timer for sampling.
Priority: -- → P2

I agree, we should drop the minimum interval to 1ms. Nazim, would you like to take this?

Flags: needinfo?(canaltinova)

Yeah sure, I'll work on this.

Assignee: nobody → canaltinova
Blocks: 1616887
Status: NEW → ASSIGNED
Flags: needinfo?(canaltinova)
See Also: → 1612251

FYI, waiting for the bug 1612251 before this.

Depends on: 1612251

We had to increase the java buffer limit to 64MiB because it was a bottleneck
and 8MiB wasn't enough for 1ms sampling rate. It was getting full pretty quick.
Even though we increased that limit, we are not going to allocate all of this
at the start. Since we are allocating the buffer chunk by chunk, we are going
to allocate only when we need.

Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9af7d0531bdf
Lower the java sampling rate to 1ms and increase the java buffer. r=gerald
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.