1464983 - Change Java Profiler's interval from 10ms to 1ms?

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Makoto Kato [:m_kato]]

When implementing JavaProfiler (bug 788022), interval's minimum is 10ms

Hardware is faster than 5 years ago, so we can change it.

Comment 1

[Makoto Kato [:m_kato]]

2ms on old phone (Galaxy Nexus / Android 4.3)
https://perfht.ml/2xtIvSL

1ms on old phone (Galaxy Nexus / Android 4.3)
https://perfht.ml/2J3hcQv

2ms on XPERIA Z3 / Android 6.0
https://perfht.ml/2xtWBUf

1ms on XPERIA Z3 / Android 6.0
https://perfht.ml/2J0pV68

1ms is unstable for resolution.  But I might try newSingleThreadScheduledExecutor instead of Timer for sampling.

Comment 2

[Markus Stange [:mstange]]

I agree, we should drop the minimum interval to 1ms. Nazim, would you like to take this?

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yeah sure, I'll work on this.

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

FYI, waiting for the bug 1612251 before this.

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1464983 - Lower the java sampling rate to 1ms and increase the java buffer. r?gerald

We had to increase the java buffer limit to 64MiB because it was a bottleneck
and 8MiB wasn't enough for 1ms sampling rate. It was getting full pretty quick.
Even though we increased that limit, we are not going to allocate all of this
at the start. Since we are allocating the buffer chunk by chunk, we are going
to allocate only when we need.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9af7d0531bdf
Lower the java sampling rate to 1ms and increase the java buffer. r=gerald

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9af7d0531bdf