Closed
Bug 1465037
Opened 7 years ago
Closed 7 years ago
Fix FrameIter principals check to work with same-compartment realms
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
6.28 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
We currently check the principals in settleOnActivation, but the principals are now on the realm and an activation will contain cross-realm calls, so the principals need to be checked for each frame instead of each activation.
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8981378 [details] [diff] [review]
Patch
Review of attachment 8981378 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense. I tried to see if I could spot a better pinchpoint for doing the check (since it's pretty serious if we miss a case), but I couldn't.
Attachment #8981378 -
Flags: review?(luke) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74279538a616
Fix FrameIter principals check to work with same-compartment realms. r=luke
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•