1465086 - 1.92 - 2.01% Heap Unclassified (windows10-64) regression on push a0414a6c423bd33ea684d97458eb7b85eb664afe (Mon May 28 2018)

Status: RESOLVED WONTFIX

(Testing :: General, defect, P3)

Description

[Ionuț Goldan [:igoldan]]

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=a0414a6c423bd33ea684d97458eb7b85eb664afe

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  2%  Heap Unclassified windows10-64 pgo stylo     40,898,630.82 -> 41,721,545.96
  2%  Heap Unclassified windows10-64 opt stylo     40,588,143.01 -> 41,368,038.70


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=13504

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests

Comment 1

[Matt Woodrow (:mattwoodrow)]

This patch enabled some debugging code that uses memory to do extra tracking. It's under MOZ_DIAGNOSTIC_ASSERT_ENABLED, so won't affect beta. I'll also back it out soon, once the investigation is complete.

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #1)
> This patch enabled some debugging code that uses memory to do extra
> tracking. It's under MOZ_DIAGNOSTIC_ASSERT_ENABLED, so won't affect beta.
> I'll also back it out soon, once the investigation is complete.

Can you approximate the end of the investigation?

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds this this should only affect nightly (currently 63).

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Closing as WONTFIX based on comment 1 as it's difficult to follow up on this after almost 2 years.