1465120 - Use a different telemetry histogram key for the storage.local IndexedDB backend

Status: VERIFIED FIXED

(WebExtensions :: Storage, enhancement, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This issue is being created as a follow up for Bug 1406181, in particular from Bug 1406181 Comment 185:

>> Is it intentional that the telemetry for both json and idb
>> backends gets put into the same histograms?  
>> That seems like it would make the data very hard to work with.
> It was intentional while I was working on the proposed set
> of patches (especially because I could use the existent
> tests to ensure that the telemetry was working on both in a
> similar way), but that is definitely an open question (...).

We agreed that having a different histograms key may be a good idea and that it was reasonable to discuss and handle it in a follow up issue while the IndexedDB backend is not yet enabled by its related about:config pref.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: request-data-review-bug-1465120.md

In the attached file, the Data Review request related to the new separate histogram keys for the storage.local APIs when using the new experimental IndexedDB backend (as also briefly described in Comment 0).

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1465120 - Use a different telemetry histogram key for the storage.local IndexedDB backend.

Review commit: https://reviewboard.mozilla.org/r/250288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250288/

Comment 3

[Chris H-C :chutten]

Comment on attachment 8984441 [details]
Bug 1465120 - Use a different telemetry histogram key for the storage.local IndexedDB backend.

https://reviewboard.mozilla.org/r/250288/#review256692

Seems like appropriate uses of the Telemetry APIs

Comment 4

[Chris H-C :chutten]

Comment on attachment 8984439 [details]
request-data-review-bug-1465120.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1

    Is the data collection request for default-on or default-off?

Default-on

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :lgreco, you will be responsible for determining whether to renew or remove the collection before expiry.

---
Result: datareview+

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8984441 [details]
Bug 1465120 - Use a different telemetry histogram key for the storage.local IndexedDB backend.

https://reviewboard.mozilla.org/r/250288/#review256768

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59ffa5c68e55
Use a different telemetry histogram key for the storage.local IndexedDB backend. r=aswan,chutten

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/59ffa5c68e55

Comment 8

[CosminB]

Attachment: Bug1465120.png

This issue is verified as fixed on Firefox 62.0a1 (20180618220118) under Win 7 64-bit and Mac OS X 10.13.3.

If extensions.webextensions.ExtensionStorageIDB.enabled is set to true, the histograms used are: 
WEBEXT_STORAGE_LOCAL_IDB_GET_MS / WEBEXT_STORAGE_LOCAL_IDB_SET_MS 

If extensions.webextensions.ExtensionStorageIDB.enabled is set to false, the histograms used are: 
WEBEXT_STORAGE_LOCAL_GET_MS / WEBEXT_STORAGE_LOCAL_SET_MS 

Please see the attached screenshot.