Closed
Bug 1465163
Opened 6 years ago
Closed 6 years ago
UbiNode changes for same-compartment realms
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
16.55 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Some UbiNode changes:
* Nodes that have a compartment() now also have a realm().
* realm() returns nullptr for cross-compartment wrappers, because they are shared by all realms within the compartment. I added a jsapi-test for this.
* Debugger::ObjectQuery checks the realm() now. We still want to check the compartment too, because we can use that to abandonReferent() - we can't abandon based on the realm check because same-compartment realms can have direct references to each other (the whole point of having same-compartment realms) so we could miss things if we did that.
Attachment #8981572 -
Flags: review?(nfitzgerald)
|
||
Comment 1•6 years ago
|
||
Comment on attachment 8981572 [details] [diff] [review]
Patch
Review of attachment 8981572 [details] [diff] [review]:
-----------------------------------------------------------------
Wonderful! Thanks jandem!
Attachment #8981572 -
Flags: review?(nfitzgerald) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee68c73f661b
Some UbiNode changes for same-compartment realms. r=fitzgen
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•