Closed Bug 1465316 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 11239 - [WebAudio] throw an error when buffer has been already set.

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11239 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11239
Details from upstream follow.

Hwanseung Lee <hs1217.lee@samsung.com> wrote:
>  [WebAudio] throw an error when buffer has been already set.
>  
>  should throw an InvalidStateError when buffer has been already
>  set in ConvolverNode
>  
>  Bug: 709656
>  Change-Id: Ia0826f9ffa2e180da1311f4cded8ff7fe5461147
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1077713
>  WPT-Export-Revision: 8bdb2a86818f79616cee8c1b16665123b9cd936b
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 10 subtests
OK     : 1
PASS   : 6
FAIL   : 4

New tests that have failures or other problems:
/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [test] 2 out of 6 assertions were failed.: FAIL
    X Set buffer a second time did not throw an exception.: FAIL
    X Set buffer to non-null to verify to throw an error did not throw an exception.: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30b7bc981844
[wpt PR 11239] - [WebAudio] throw an error when buffer has been already set., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/323c428c16c5
[wpt PR 11239] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/30b7bc981844
https://hg.mozilla.org/mozilla-central/rev/323c428c16c5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.