1465403 - MacOS menu and touchbar icons are blurry when SVG is used

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Tim Nguyen :ntim]

Attachment: Screen Shot 2018-05-30 at 1.27.51 PM.png

Comment 1

[Stephen A Pohl [:spohl]]

What icons is this referring to? If the size of the SVG is doubled and then scaled to 50%, does this reproduce?

Comment 2

[Jonathan Watt [:jwatt]]

There are quite a few SVG bugs open for the SVG being rendered in images at the wrong resolution. For example, bug 986403. Several years ago I dug into one of them a bit, but every time I got to an "ah-hah, got it!" moment, it turned out not to be a red herring. From what I recall I last suspected that on HiDPI we were doing something wrong somewhere with CSS px to dev pixel conversion, but I never tracked down the source of the bug I was looking into at the time.

Comment 3

[Tim Nguyen :ntim]

(In reply to Stephen A Pohl [:spohl] from comment #1)
> What icons is this referring to? If the size of the SVG is doubled and then
> scaled to 50%, does this reproduce?

The icons in the "Bookmarks" menu, this is mostly visible if you enable a dark menu bar on macOS.

Yes, it works if we double the size of SVG from 16 to 32, but it would be nice if the widget code handled this without such hacks.

Comment 4

[Timothy Nikkel (:tnikkel)]

Bug 1174284 is technically for a different problem but I think the comments there outline how to fix this in the widget code.

Comment 6

[Harry Twyford]

Attachment: Bug 1465403 - Support loading icons @2x in macOS menu bars. r?mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9154f62e7c76
Support loading icons @2x in macOS menu bars. r=mstange

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9154f62e7c76