1465554 - Performance anti-pattern in UI

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Sara Seif Afjehei]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.40 Safari/537.36

Steps to reproduce:

Hello guys!

I found that in BackForwardTableViewCell, there is an imageView border colored with alpha 0.1. I think it would be better not to use transparent or partially transparent views in repeating styles, like TableViewCells and inside for loops.

Due to my own experience and this Apple document, using transparency could be tricky, performance-wise.

Also blur effect is expensive to render, and again you are adding this as a content view background in ThumbnailCell.



Expected results:



Don't you think the code should be refactored to remove this anti-pattern?

Comment 1

[Justin D'Arcangelo [:justindarc]]

Would you like to submit a patch for this?

Comment 2

[Sara Seif Afjehei]

I tried removing transparency from borders in BackForwardTableViewCell, and profiled the performance (while scrolling the tableview as fast as I could) with and without transparent border, here is the result I got:

Table Row Count: 30 => AVG CPU Usage after removing transparency: 38.1% , AVG CPU Usage before removing transparency: 44.5%

Table Row Count: 20 => AVG CPU Usage after removing transparency: 39.5% , AVG CPU Usage before removing transparency: 42.9%

I think the design is not even changed so much. So I would recommend removing it if possible.

Comment 3

[Justin D'Arcangelo [:justindarc]]

(In reply to Sara Seif Afjehei from comment #2)
> I tried removing transparency from borders in BackForwardTableViewCell, and
> profiled the performance (while scrolling the tableview as fast as I could)
> with and without transparent border, here is the result I got:
> 
> Table Row Count: 30 => AVG CPU Usage after removing transparency: 38.1% ,
> AVG CPU Usage before removing transparency: 44.5%
> 
> Table Row Count: 20 => AVG CPU Usage after removing transparency: 39.5% ,
> AVG CPU Usage before removing transparency: 42.9%
> 
> I think the design is not even changed so much. So I would recommend
> removing it if possible.

Do you have a pull-request we could take a look at?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.