1465643 - DualShock 4 has different axis amount between wireless and wired mode on Windows

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P3)

Description

[Daosheng Mu[:daoshengmu]]

DualShock 4 in Firefox,

Wireless DS4: 18 buttons, 15 axes
Wired DS4: 18 buttons, 8 axes

-------
In Chrome,
Both of wireless and wired modes have 18 buttons and 4 axes.

Comment 1

[Daosheng Mu[:daoshengmu]]

For the #remapping section [1], we should consider to manage a gamepad mapping list for different gamepad vendors. I notice gamepad vendors have their own mapping rule and most of them are different. Now, I can use hid and call GetValueCaps() to get the same amount for wired and wireless mode with 10 axes, but we have to deal the mapping rule.

Btw, on MacOS, DS4 has 18 btns and 6 axes.

[1] https://www.w3.org/TR/gamepad/#remapping

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1465643 - Part 2: Remapping DualShock 4 buttons and axes on Windows.

Comment 3

[Daosheng Mu[:daoshengmu]]

IIUC, the part of dpadCaps code in WindowsGamepad [1] will never been entered, the hasDpad condition is somehow been broken and useless. I am going to remove these code and use our new remapping mechanism to replace it. In DefaultRemapper class, I would like to just return HID raw data.

[1] https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/dom/gamepad/windows/WindowsGamepad.cpp#733

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1465643 - Part 1: Removing unused hasDpad logic in WindowsGamepad.cpp.

Comment 5

[Daosheng Mu[:daoshengmu]]

For other gamepads' remappers, I would like to file an another bug once this lands.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9133f02b68c4
Part 1: Removing unused hasDpad logic in WindowsGamepad.cpp. r=qdot
https://hg.mozilla.org/integration/autoland/rev/3c267ad86e3c
Part 2: Remapping DualShock 4 buttons and axes on Windows. r=qdot

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9133f02b68c4
https://hg.mozilla.org/mozilla-central/rev/3c267ad86e3c