authenticated LDAP autocompletion autopicks current addr after password entered

VERIFIED FIXED in mozilla1.0.1

Status

P1
major
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

(Blocks: 1 bug, {dataloss})

Trunk
mozilla1.0.1
dataloss
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ADT2 RTM])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

17 years ago
When doing an LDAP autocomplete, when the user is entering a password, this
gives away focus to the nsIAuthPrompt password dialog.  This confuses the
autocomplete widget into thinking that it's done, and it automatically accepts
the currently selected address.  If a user isn't paying close attention, they
could possibly send mail to someone they didn't intend.

Current theory on fixing this: I'll add an attribute to the autocomplete widget
which allows the widget to run in a mode where it ignores loss of focus messages
until all the sub-sessions have completed.  Or perhaps at least until the menu
has dropped down.  Need to make sure this doesn't add any weird side effects,
like leaving the menu up indefinitely if a server doesn't respond.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: dataloss, nsbeta1
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla1.0.1
(Assignee)

Updated

17 years ago
Depends on: 135778
(Assignee)

Updated

17 years ago
Priority: -- → P2
(Assignee)

Updated

17 years ago
Blocks: 148891
(Assignee)

Updated

17 years ago
No longer depends on: 135778

Comment 1

17 years ago
Discussed in mail news bug meeting.  Decided to plus this bug.
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [ADT2 RTM]
(Assignee)

Comment 2

17 years ago
Created attachment 87090 [details] [diff] [review]
patch, v1

First cut at a patch for this.	Need to talk some issues over with hewitt
before I'm super-confident, however.
(Assignee)

Updated

17 years ago
Priority: P2 → P1
(Assignee)

Comment 3

17 years ago
Created attachment 87167 [details] [diff] [review]
patch, v2

Tweaked a few things after discussion with hewitt.  Joe, can you review this
version?
Attachment #87090 - Attachment is obsolete: true
(Assignee)

Comment 4

17 years ago
Created attachment 87168 [details] [diff] [review]
patch, v3

Fixed bogus comment.
Attachment #87167 - Attachment is obsolete: true
(Assignee)

Updated

17 years ago
Blocks: 150723

Comment 5

17 years ago
Comment on attachment 87168 [details] [diff] [review]
patch, v3

sr=hewitt
Attachment #87168 - Flags: superreview+

Comment 6

17 years ago
Comment on attachment 87168 [details] [diff] [review]
patch, v3

r=blake
Attachment #87168 - Flags: review+
(Assignee)

Comment 7

17 years ago
Fix checked into the trunk; still needs to land on the branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Keywords: adt1.0.1, mozilla1.0.1
Resolution: --- → FIXED

Comment 8

17 years ago
yulian, could you verify this on the trunk?

Comment 9

17 years ago
Verified with 20020613 Trunk builds on WIn2K and Linux platforms.

Comment 10

17 years ago
adt1.0.1+ added
Keywords: adt1.0.1 → adt1.0.1+
Comment on attachment 87168 [details] [diff] [review]
patch, v3

Please land this on the 1.0.1 branch.  Once there, replace the
"mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.
Attachment #87168 - Flags: approval+
Keywords: mozilla1.0.1 → mozilla1.0.1+
(Assignee)

Comment 12

17 years ago
Checked into the branch.
Keywords: mozilla1.0.1+ → fixed1.0.1

Comment 13

17 years ago
Verified with 20020617 Branch builds on Win2K and Linux platforms.
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.1 → verified1.0.1
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.