Closed Bug 146569 Opened 22 years ago Closed 22 years ago

authenticated LDAP autocompletion autopicks current addr after password entered

Categories

(MailNews Core :: LDAP Integration, defect, P1)

Product:
MailNews Core
Component:
LDAP Integration
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

(Keywords: dataloss, Whiteboard: [ADT2 RTM])

Attachments

(1 file, 2 obsolete files)

patch, v3
2.96 KB, patch
bugzilla
: review+
hewitt
: superreview+
dbaron
: approval+
Details | Diff | Splinter Review
When doing an LDAP autocomplete, when the user is entering a password, this gives away focus to the nsIAuthPrompt password dialog. This confuses the autocomplete widget into thinking that it's done, and it automatically accepts the currently selected address. If a user isn't paying close attention, they could possibly send mail to someone they didn't intend. Current theory on fixing this: I'll add an attribute to the autocomplete widget which allows the widget to run in a mode where it ignores loss of focus messages until all the sub-sessions have completed. Or perhaps at least until the menu has dropped down. Need to make sure this doesn't add any weird side effects, like leaving the menu up indefinitely if a server doesn't respond.
Status: NEW → ASSIGNED
Keywords: dataloss, nsbeta1
Target Milestone: --- → mozilla1.0.1
Depends on: 135778
Priority: -- → P2
Blocks: 148891
No longer depends on: 135778
Discussed in mail news bug meeting. Decided to plus this bug.
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [ADT2 RTM]
Attached patch patch, v1 (obsolete) — — Splinter Review
First cut at a patch for this. Need to talk some issues over with hewitt before I'm super-confident, however.
Priority: P2 → P1
Attached patch patch, v2 (obsolete) — — Splinter Review
Tweaked a few things after discussion with hewitt. Joe, can you review this version?
Attachment #87090 - Attachment is obsolete: true
Attached patch patch, v3 — — Splinter Review
Fixed bogus comment.
Attachment #87167 - Attachment is obsolete: true
Blocks: 150723
Comment on attachment 87168 [details] [diff] [review] patch, v3 sr=hewitt
Attachment #87168 - Flags: superreview+
Comment on attachment 87168 [details] [diff] [review] patch, v3 r=blake
Attachment #87168 - Flags: review+
Fix checked into the trunk; still needs to land on the branch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: adt1.0.1, mozilla1.0.1
Resolution: --- → FIXED
yulian, could you verify this on the trunk?
Verified with 20020613 Trunk builds on WIn2K and Linux platforms.
adt1.0.1+ added
Keywords: adt1.0.1 → adt1.0.1+
Comment on attachment 87168 [details] [diff] [review] patch, v3 Please land this on the 1.0.1 branch. Once there, replace the "mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.
Attachment #87168 - Flags: approval+
Checked into the branch.
Keywords: mozilla1.0.1+ → fixed1.0.1
Verified with 20020617 Branch builds on Win2K and Linux platforms.
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.1 → verified1.0.1
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: