Add follow_urlbar_link event telemetry for Savant Shield study

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bdanforth, Assigned: bdanforth)

Tracking

unspecified
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed, firefox62 fixed)

Details

Attachments

(1 attachment)

This is one of a series of bugs that together comprise the Savant Shield study (tracking bug 1457226).

This bug will register and record (for the duration of the study only):
* When the user clicks on a history link displayed by the awesomebar
* When the user clicks on a bookmark link displayed by the awesomebar
Assignee

Updated

a year ago
Blocks: 1457226
Assignee

Updated

a year ago
Depends on: 1462725
Assignee

Updated

a year ago
Assignee: nobody → bdanforth
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request)
Assignee

Comment 2

a year ago
:pdehaan, could you provide QA review on this patch? Instructions for obtaining the test build are here: https://github.com/biancadanforth/gecko-dev/issues/5
Flags: needinfo?(pdehaan)
Assignee

Comment 3

a year ago
I neglected to mention that for the event telemetry to show up in `about:telemetry#events-tab`, the study pref `shield.savant.enabled` needs to be set to `true`. Normandy will take care of turning this pref ON and OFF when the study is officially launched.

Comment 4

a year ago
mozreview-review
Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

https://reviewboard.mozilla.org/r/249552/#review256052

Simple enough, thanks
Attachment #8983719 - Flags: review?(adw) → review+
Attachment #8983719 - Flags: review?(mak77)
Clearing the r? on Marco since I think you wanted one of us to review first come first serve, but feel free to look at this too Marco of course
R+.
I was able to get a "follow_urlbar_link" event while navigating to a previously visited/bookmarked site via the awesome bar.

timestamp | category | method             | object  | Value | extra 
----------|----------|--------------------|---------|-------|-------------------------------
1037682   | savant   | follow_urlbar_link | history | null  | {"subcategory": "navigation"}
Flags: needinfo?(pdehaan)
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/674d58c3a8f3
Add follow_urlbar_link event telemetry for Savant Shield study; r=adw
Assignee

Updated

a year ago
Summary: Add follow_awesomebar_link event telemetry for Savant Shield study → Add follow_urlbar_link event telemetry for Savant Shield study

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/674d58c3a8f3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Assignee

Comment 10

a year ago
Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

Approval Request Comment
[Feature/Bug causing the regression]: There is no regression. The tracking bug for this study is 1457226.
[User impact if declined]: None. This patch is part of a priority Shield study.
[Is this code covered by automated tests?]: There are no study-specific tests, but all code has been run on the try server for regression testing and has been approved by both a Firefox peer and QA (pdehaan).
[Has the fix been verified in Nightly?]: The study’s functionality has been verified in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: This request applies to all patches in this bug. In general, here is a comprehensive list of bugs whose patches need to be uplifted (in this order) to complete the study: 1462725, 1465698, 1465707, 1465703, 1465704, 1465697, 1465685, 1465694
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is an observational pref-flip study with no branches and no UI. It adds some event telemetry probes in various places and a study module to enable/disable collection. Each patch has been QA tested and R+ by pdehaan.
[String changes made/needed]: None.
Attachment #8983719 - Flags: approval-mozilla-beta?
Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

Telemetry code needed to support the Fx61 Savant work. Approved for 61.0b13.
Attachment #8983719 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.