1465704 - Add follow_urlbar_link event telemetry for Savant Shield study

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P1)

Description

[Bianca Danforth [:bdanforth]]

This is one of a series of bugs that together comprise the Savant Shield study (tracking bug 1457226).

This bug will register and record (for the duration of the study only):
* When the user clicks on a history link displayed by the awesomebar
* When the user clicks on a bookmark link displayed by the awesomebar

Comment 1

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

These probes will register and record (for the duration of the study only):
* When the user clicks on a history link displayed by the urlbar
* When the user clicks on a bookmark link displayed by the urlbar

It should be noted that the same site can be multiple result types at the same time, so there will be times when a bookmark and/or history selection is captured as a result type other than bookmark or history (e.g. 'switchtab', 'autofill' or 'visiturl').

Review commit: https://reviewboard.mozilla.org/r/249552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249552/

Comment 2

[Bianca Danforth [:bdanforth]]

:pdehaan, could you provide QA review on this patch? Instructions for obtaining the test build are here: https://github.com/biancadanforth/gecko-dev/issues/5

Comment 3

[Bianca Danforth [:bdanforth]]

I neglected to mention that for the event telemetry to show up in `about:telemetry#events-tab`, the study pref `shield.savant.enabled` needs to be set to `true`. Normandy will take care of turning this pref ON and OFF when the study is officially launched.

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

https://reviewboard.mozilla.org/r/249552/#review256052

Simple enough, thanks

Comment 5

[Drew Willcoxon :adw]

Clearing the r? on Marco since I think you wanted one of us to review first come first serve, but feel free to look at this too Marco of course

Comment 6

[Peter deHaan [:pdehaan]]

R+.
I was able to get a "follow_urlbar_link" event while navigating to a previously visited/bookmarked site via the awesome bar.

timestamp | category | method             | object  | Value | extra 
----------|----------|--------------------|---------|-------|-------------------------------
1037682   | savant   | follow_urlbar_link | history | null  | {"subcategory": "navigation"}

Comment 7

[Bianca Danforth [:bdanforth]]

Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/249552/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674d58c3a8f3
Add follow_urlbar_link event telemetry for Savant Shield study; r=adw

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/674d58c3a8f3

Comment 10

[Bianca Danforth [:bdanforth]]

Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

Approval Request Comment
[Feature/Bug causing the regression]: There is no regression. The tracking bug for this study is 1457226.
[User impact if declined]: None. This patch is part of a priority Shield study.
[Is this code covered by automated tests?]: There are no study-specific tests, but all code has been run on the try server for regression testing and has been approved by both a Firefox peer and QA (pdehaan).
[Has the fix been verified in Nightly?]: The study’s functionality has been verified in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: This request applies to all patches in this bug. In general, here is a comprehensive list of bugs whose patches need to be uplifted (in this order) to complete the study: 1462725, 1465698, 1465707, 1465703, 1465704, 1465697, 1465685, 1465694
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is an observational pref-flip study with no branches and no UI. It adds some event telemetry probes in various places and a study module to enable/disable collection. Each patch has been QA tested and R+ by pdehaan.
[String changes made/needed]: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8983719 [details]
Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study;

Telemetry code needed to support the Fx61 Savant work. Approved for 61.0b13.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/16a92f7f6fba