Closed Bug 1465715 Opened 7 years ago Closed 7 years ago

Re-enable early return of `raise_for_port` in case the application already exited

Categories

(Remote Protocol :: Marionette, enhancement, P3)

Product:
Remote Protocol
Component:
Marionette
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: whimboo, Unassigned)

References

Details

As part of my work on bug 1433905 I have to comment out the following lines in marionette.py: https://dxr.mozilla.org/mozilla-central/rev/5866d6685849311f057e7e229b9ace63a2641c29/testing/marionette/client/marionette_driver/marionette.py#695-697 Reason is that `runner.is_running()` which is based on `returncode` always returned `True` before my changes. Now with returning the correct value of the sub process `returncode` the test `test_refresh_firefox.py` will fail because it performs a lot of work during the restart and as it looks like escapes the io completion port. This is more work as I expect to do on bug 1433905 which is for mozprocess purely. So I will take care of re-enabling this feature once the refactoring on bug 1433873 has been fixed.
See Also: → 1433905
Priority: -- → P3
Blocks: 1432792
Finally there was actually no need to comment out this code, and the patch on bug 1433873 just updated it to make if fail safe. As such there is nothing to do for this bug anymore. https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/testing/marionette/client/marionette_driver/marionette.py#712-714
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.