1465728 - Remove the compartment name callback

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jan de Mooij [:jandem]]

This requires some XPConnect surgery: the location info in CompartmentPrivate needs to live in RealmPrivate, and after that we can remove the compartment name callback and use the realm name callback everywhere.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Move location and locationURI fields from CompartmentPrivate to RealmPrivate

The xpcprivate.h changes are just code motion, except I changed the order of the GetLocationURI methods to get a much more readable diff.

I'll rename Cu.getCompartmentLocation in a different patch.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Remove the compartment name callback

I renamed CompartmentNameCallback to GetRealmNameCallback ("Get" prefix), to avoid conflicts with the JS::RealmNameCallback type.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - Rename Cu.getCompartmentLocation to Cu.getRealmLocation

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8982150 [details] [diff] [review]
Part 1 - Move location and locationURI fields from CompartmentPrivate to RealmPrivate

r=me

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8982153 [details] [diff] [review]
Part 3 - Rename Cu.getCompartmentLocation to Cu.getRealmLocation

r=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d422fb97474
part 1 - Move location and locationURI fields from CompartmentPrivate to RealmPrivate. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/84aa50d4663a
part 2 - Remove the compartment name callback. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7f3a604779
part 3 - Rename Cu.getCompartmentLocation to Cu.getRealmLocation. r=bz

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2d422fb97474
https://hg.mozilla.org/mozilla-central/rev/84aa50d4663a
https://hg.mozilla.org/mozilla-central/rev/ff7f3a604779