Closed Bug 1465746 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 11267 - webrtc wpt: check signalingState before addIceCandidate

Categories

(Core :: WebRTC, enhancement, P4)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11267 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11267
Details from upstream follow.

Philipp Hancke <philipp.hancke@googlemail.com> wrote:
>  webrtc wpt: check signalingState before addIceCandidate
>  
>  in order to avoid issues with calling addIceCandidate
>  when the peerconnection is closed
>  
>  BUG=836871
>  
>  Change-Id: I698f5365a4e1b72a812fbc5e3adf5e51586718a6
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1079550
>  WPT-Export-Revision: daf051a01d460abae9a55bf5821173b5a225adb2
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 44 tests and 272[linux32-opt,linux64-opt], 271[linux32-debug] subtests
OK     : 36
PASS   : 145[linux32-debug], 146[linux32-opt,linux64-opt]
FAIL   : 115
TIMEOUT: 16

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4adf72720fbb
[wpt PR 11267] - webrtc wpt: check signalingState before addIceCandidate, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a178a380ac06
[wpt PR 11267] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b778f39b883b
[wpt PR 11267] - webrtc wpt: check signalingState before addIceCandidate, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/641e9a242de3
[wpt PR 11267] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/b778f39b883b
https://hg.mozilla.org/mozilla-central/rev/641e9a242de3
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.