1465746 - [wpt-sync] Sync PR 11267 - webrtc wpt: check signalingState before addIceCandidate

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11267 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11267
Details from upstream follow.

Philipp Hancke <[e-mail]> wrote:
>  webrtc wpt: check signalingState before addIceCandidate
>  
>  in order to avoid issues with calling addIceCandidate
>  when the peerconnection is closed
>  
>  BUG=836871
>  
>  Change-Id: I698f5365a4e1b72a812fbc5e3adf5e51586718a6
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1079550
>  WPT-Export-Revision: daf051a01d460abae9a55bf5821173b5a225adb2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b1158ce4394536609d7981d25622be30522b35b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b915b5ee830a4e77935504422aad3184ad8bce2

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 44 tests and 272[linux32-opt,linux64-opt], 271[linux32-debug] subtests
OK     : 36
PASS   : 145[linux32-debug], 146[linux32-opt,linux64-opt]
FAIL   : 115
TIMEOUT: 16

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
/webrtc/RTCPeerConnection-setRemoteDescription-offer.html

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc0193bf42c6262624a9d45c6824ec003aee814b

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2a3faef6fd7ba7af559090adc7beaa80da08c3d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4adf72720fbb
[wpt PR 11267] - webrtc wpt: check signalingState before addIceCandidate, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a178a380ac06
[wpt PR 11267] - Update wpt metadata, a=testonly

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b778f39b883b
[wpt PR 11267] - webrtc wpt: check signalingState before addIceCandidate, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/641e9a242de3
[wpt PR 11267] - Update wpt metadata, a=testonly

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b778f39b883b
https://hg.mozilla.org/mozilla-central/rev/641e9a242de3