Closed
Bug 1465762
Opened 6 years ago
Closed 6 years ago
Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
This is continuing roll-out of require-expected-throws-or-rejects as per bug 1452706.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8982205 [details] Bug 1465762 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. https://reviewboard.mozilla.org/r/248188/#review254468 thanks!
Attachment #8982205 -
Flags: review?(aswan) → review+
| Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6630148c9bea Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. r=aswan
|
||
Comment 6•6 years ago
|
||
Backed out for xpcshell failures on test_ext_schemas_async.js Backout: https://hg.mozilla.org/integration/autoland/rev/4bec004cc30f3f89da176783f21a6e24336e481a Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=181294227&repo=autoland&lineNumber=1652
Flags: needinfo?(standard8)
|
Assignee | |
Comment 7•6 years ago
|
||
That's kinda weird, they failed in debug mode, even though the exception message is the same... I'll try and figure something out.
Flags: needinfo?(standard8)
|
|
Assignee | |
Comment 8•6 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #7) > That's kinda weird, they failed in debug mode, even though the exception > message is the same... I'll try and figure something out. Oh, that would be because of the `if (AppConstants.DEBUG)` wrapper around these tests in the code...
| Comment hidden (mozreview-request) |
|
||
Comment 10•6 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8518549e6bb6 Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. r=aswan
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8518549e6bb6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Comment 12•6 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(standard8)
|
|
Assignee | |
Comment 13•6 years ago
|
||
No manual testing required, this affects unit tests only.
Flags: needinfo?(standard8)
|
|
||
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•