Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla62
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
This is continuing roll-out of require-expected-throws-or-rejects as per bug 1452706.
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8982205 [details]
Bug 1465762 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions.

https://reviewboard.mozilla.org/r/248188/#review254468

thanks!
Attachment #8982205 - Flags: review?(aswan) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6630148c9bea
Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. r=aswan
Assignee

Comment 7

a year ago
That's kinda weird, they failed in debug mode, even though the exception message is the same... I'll try and figure something out.
Flags: needinfo?(standard8)
Assignee

Comment 8

a year ago
(In reply to Mark Banner (:standard8) from comment #7)
> That's kinda weird, they failed in debug mode, even though the exception
> message is the same... I'll try and figure something out.

Oh, that would be because of the `if (AppConstants.DEBUG)` wrapper around these tests in the code...
Comment hidden (mozreview-request)

Comment 10

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8518549e6bb6
Enable ESLint rule require-expected-throws-or-rejects for toolkit/**/extensions. r=aswan

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8518549e6bb6
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee

Updated

a year ago
Blocks: 1466497
Assignee

Updated

a year ago
No longer blocks: 1466497

Comment 12

a year ago
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(standard8)
Assignee

Comment 13

a year ago
No manual testing required, this affects unit tests only.
Flags: needinfo?(standard8)

Updated

a year ago
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.