Closed Bug 1465866 Opened 2 years ago Closed 2 years ago

Remove methods from ScrollBoxObject

Categories

(Core :: XUL, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: emalysz, Assigned: emalysz, NeedInfo)

References

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Attached patch removes unused methods (obsolete) — Splinter Review
Attachment #8982287 - Attachment is patch: true
Attachment #8982287 - Attachment mime type: text/x-c++src → text/plain
Attachment #8982287 - Attachment is obsolete: true
Attachment #8982296 - Attachment is obsolete: true
Attachment #8982580 - Flags: review?(enndeakin)
Comment on attachment 8982580 [details]
Bug 1465866: removes methods from ScrollBoxObject and deletes unneccessary spacing +6102

https://reviewboard.mozilla.org/r/248558/#review254826

This looks good, but let's test it. Watch here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=371cb71e84d75358c6d51ae8eca274687f9ced18

::: commit-message-763f3:3
(Diff revision 1)
> +Bug #1465866: remove methods from ScrollBoxObject
> +
> +MozReview-Commit-ID: GrwTPJYai6O

You should make sure that the patch has a commit message for it. Also, make sure your 'name' is configured in 'hg'.

::: layout/xul/ScrollBoxObject.cpp:290
(Diff revision 1)
>                                   nsIPresShell::ScrollAxis(),
>                                   nsIPresShell::ScrollAxis(),
>                                   nsIPresShell::SCROLL_FIRST_ANCESTOR_ONLY |
>                                   nsIPresShell::SCROLL_OVERFLOW_HIDDEN);
>  }
> -
> +    

These is some extra space here that should be removed.
Attachment #8982637 - Attachment is obsolete: true
Priority: -- → P3
Comment on attachment 8982580 [details]
Bug 1465866: removes methods from ScrollBoxObject and deletes unneccessary spacing +6102

https://reviewboard.mozilla.org/r/248558/#review255608

Thank you for fixing this!  It's nice to see the cruft disappear.  ;)

::: dom/webidl/ScrollBoxObject.webidl
(Diff revision 3)
> -   *
> -   * Get the current scroll position in css pixels.
> -   * @see scrollTo for the definition of x and y.
> -   */
> -  [Throws]
> -  void getPosition(object x, object y);

This is used in a few places in comm-central (in calendar/ and im/).  Please file a bug on them to update to positionX/Y?

::: dom/webidl/ScrollBoxObject.webidl
(Diff revision 3)
> -
> -  /**
> -   * DEPRECATED: Please use scrolledWidth and scrolledHeight
> -   */
> -  [Throws]
> -  void getScrolledSize(object width, object height);

This is also used in im/ in comm-central.  Probably just mention it in the same bug?
Attachment #8982580 - Flags: review?(bzbarsky) → review+
Depends on: 1469014
Is this ready to be checked in?
Flags: needinfo?(emalysz)
Blocks: 1454358
No longer depends on: 1454358
Comment on attachment 8982580 [details]
Bug 1465866: removes methods from ScrollBoxObject and deletes unneccessary spacing +6102

https://reviewboard.mozilla.org/r/248558/#review261314
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 79940d7a5e2d needs "Bug N" or "No bug" in the commit message.
remote: Emma Malysz <emalysz@mozilla.com>
remote: Bug #1465866: removes methods from ScrollBoxObject and deletes unneccessary spacing r=bz+6102
remote: 
remote: MozReview-Commit-ID: GrwTPJYai6O
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/058b07756df6
removes methods from ScrollBoxObject and deletes unneccessary spacing r=bz+6102
https://hg.mozilla.org/mozilla-central/rev/058b07756df6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Any particular reason for these white-space changes?
https://hg.mozilla.org/mozilla-central/rev/058b07756df6#l2.169
You need to log in before you can comment on or make changes to this bug.