1465875 - Get rid of nsIDOMNSEditableElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Eliminate pointless QIs to nsIDOMNSEditableElement

We expose the relevant APIs on textarea and input elements anyway
(chromeonly).  The QIs will throw on a non-input or non-textarea element, but
none of these consumers expect that to happen.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Eliminate use of "instanceof nsIDOMNSEditablElement"

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Eliminate C++ use of nsIDOMNSEditableElement

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Eliminate random mentions of nsIDOMNSEditableElement

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Eliminate nsIDOMNSEditableElement

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8982565 [details] [diff] [review]
part 2.  Eliminate use of "instanceof nsIDOMNSEditablElement"

Review of attachment 8982565 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/editabletext/editabletext.js
@@ +205,3 @@
>        return elm.value;
>  
> +    if (elmClass == "HTMLDocument")

nit: ===

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ef0eb8cbf3b
part 1.  Eliminate pointless QIs to nsIDOMNSEditableElement.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c9969cf727a
part 2.  Eliminate use of "instanceof nsIDOMNSEditablElement".  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/51f14f44ca9c
part 3.  Eliminate C++ use of nsIDOMNSEditableElement.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf9522e0558
part 4.  Eliminate random mentions of nsIDOMNSEditableElement.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/284705205651
part 5.  Eliminate nsIDOMNSEditableElement.  r=qdot

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3398f70632d6
followup.  Fix some Android code that ends up with null elements and was getting false from instanceof as a result.  r=bzbarsky

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3ef0eb8cbf3b
https://hg.mozilla.org/mozilla-central/rev/7c9969cf727a
https://hg.mozilla.org/mozilla-central/rev/51f14f44ca9c
https://hg.mozilla.org/mozilla-central/rev/fcf9522e0558
https://hg.mozilla.org/mozilla-central/rev/284705205651
https://hg.mozilla.org/mozilla-central/rev/3398f70632d6