Closed Bug 1465875 Opened 2 years ago Closed 2 years ago

Get rid of nsIDOMNSEditableElement

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(5 files)

No description provided.
Blocks: 1132934
We expose the relevant APIs on textarea and input elements anyway
(chromeonly).  The QIs will throw on a non-input or non-textarea element, but
none of these consumers expect that to happen.
Attachment #8982564 - Flags: review?(kyle)
Attachment #8982564 - Flags: review?(kyle) → review+
Comment on attachment 8982565 [details] [diff] [review]
part 2.  Eliminate use of "instanceof nsIDOMNSEditablElement"

Review of attachment 8982565 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/editabletext/editabletext.js
@@ +205,3 @@
>        return elm.value;
>  
> +    if (elmClass == "HTMLDocument")

nit: ===
Attachment #8982565 - Flags: review?(kyle) → review+
Attachment #8982566 - Flags: review?(kyle) → review+
Attachment #8982567 - Flags: review?(kyle) → review+
Attachment #8982568 - Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ef0eb8cbf3b
part 1.  Eliminate pointless QIs to nsIDOMNSEditableElement.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c9969cf727a
part 2.  Eliminate use of "instanceof nsIDOMNSEditablElement".  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/51f14f44ca9c
part 3.  Eliminate C++ use of nsIDOMNSEditableElement.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf9522e0558
part 4.  Eliminate random mentions of nsIDOMNSEditableElement.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/284705205651
part 5.  Eliminate nsIDOMNSEditableElement.  r=qdot
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3398f70632d6
followup.  Fix some Android code that ends up with null elements and was getting false from instanceof as a result.  r=bzbarsky
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.