Ignore contain:paint for cases determined in the spec

RESOLVED FIXED in Firefox 62

Status

()

P3
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: yusuf, Assigned: yusuf, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 months ago
Currently, we are changing display:inline as display:inline-block at servo/components/style/style_adjuster.rs:adjust_for_contain()

According to spec:

"If the element does not generate a principal box (as is the case with display: contents or display: none), or if the element is an internal table element other than display: table-cell, or if the element is an internal ruby element, or if the element’s principal box is a non-atomic inline-level box, paint containment has no effect."[1]

meaning that we need to update the code to ignore contain:paint for remaining cases given above (e.g. non-atomic inline-level box)

[1] https://drafts.csswg.org/css-contain/#containment-paint
(In reply to Yusuf Sermet [:yusuf] from comment #0)
> Currently, we are changing display:inline as display:inline-block at
> servo/components/style/style_adjuster.rs:adjust_for_contain()

I think this ^ rust code *does* need changing or even removing [since it's for spec text that no longer exists], but I think that's unrelated to the "Ignore contain:paint for these cases" spec text that you're focusing this bug on.

So: let's maybe do those rust changes elsewhere (either in bug 1465250 or in another bug), and let's focus this bug on adding whatever "ignoring" logic is necessary (probably in C++ code), and tests to be sure we are indeed ignoring as-needed.

Thanks!
(I don't imagine the display:none/display:contents scenarios will need any code changes, though I think you can write a *reftest* for the "display:contents" scenario, and it'd be worth doing so. You probably would want to start with your testcase from bug 1465250, and then add "display:contents" to the "contain:paint" element -- then you'd want to verify that the children with z-index *do indeed interleave* with their ancestors that have z-index.  Basically, just asserting that no stacking context is generated for the display:contents;contain:paint thing.)
(Assignee)

Comment 3

10 months ago
(In reply to Daniel Holbert [:dholbert] from comment #1)

Rust changes has been done in bug 1465250 (https://bugzilla.mozilla.org/show_bug.cgi?id=1465250#c19). Thanks!

(In reply to Daniel Holbert [:dholbert] from comment #2)

Thanks for the advice! I wrote the test and the ref for the display:contents scenario. I'll push it when the other scenarios are ready as well.
(Assignee)

Comment 5

10 months ago
mozreview-review
Comment on attachment 8983602 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/249462/#review255630

::: commit-message-c3a61:1
(Diff revision 1)
> +Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines. r=dholbert

To recap, spec says contain:paint should not have any effect for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines. For all these cases, the code is now updated, and relevant reftests are added. I have few questions or notes:

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html:44
(Diff revision 1)
> +    <div class="group">
> +      <div class="background"></div>
> +      <ruby><rbc>&emsp;<div class="contained"></div></rbc></ruby>
> +    </div>

For internal ruby elements (<rb>, <rbc>, <rt>, <rtc>), I realized <rbc> is not listed in the website anymore (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rtc). Is <rbc> in the deprecation process by any chance? The reason I'm asking is only <rbc> seems to be not working in above test for both stacking context and overflow clipping. It seems to work for containing block, though.

::: layout/reftests/w3c-css/submitted/contain/reftest.list:16
(Diff revision 1)
> +== contain-paint-ignored-cases-ruby-containing-block-001.html contain-paint-ignored-cases-ruby-containing-block-001-ref.html
> +== contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html contain-paint-ignored-cases-ruby-stacking-and-clipping-001-ref.html

Currently, we are checking these internal ruby elements for 3 out of 4 requirements of the contain:paint (i.e. overflow clipping, stacking context, containing block). Is it necessarry to write a test case for checking the formatting context as well? Because Ruby containers already establishes their own formatting context, so writing a test case may be trivial.

::: layout/style/nsStyleStruct.h:2451
(Diff revision 1)
>    bool IsContainPaint() const {
> -    return NS_STYLE_CONTAIN_PAINT & mContain;
> +    return (NS_STYLE_CONTAIN_PAINT & mContain) &&
> +           !IsInternalRubyDisplayType() &&
> +           !IsInternalTableStyleExceptCell();
>    }

We are filtering contain:paint for these cases here in the display level for the sake of high cohesion and cleaner code. As I consulted dholbert, not doing these checks in the frame level should not create an issue practically.

Comment 6

10 months ago
mozreview-review-reply
Comment on attachment 8983602 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/249462/#review255630

> For internal ruby elements (<rb>, <rbc>, <rt>, <rtc>), I realized <rbc> is not listed in the website anymore (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rtc). Is <rbc> in the deprecation process by any chance? The reason I'm asking is only <rbc> seems to be not working in above test for both stacking context and overflow clipping. It seems to work for containing block, though.

I'm not sure, though be aware that the real thing that matters here are the CSS display values. <rbc> corresponds to display:ruby-base-container, which is specced at https://drafts.csswg.org/css-ruby-1/#ruby-display

It looks like we do support display:ruby-base-container, e.g. we use it here: https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/layout/style/res/ua.css#115

So I think it is something you need to consider. I'd suggest looking for usages in testcases, and xidorn is probably the best authority on its specifics.

> Currently, we are checking these internal ruby elements for 3 out of 4 requirements of the contain:paint (i.e. overflow clipping, stacking context, containing block). Is it necessarry to write a test case for checking the formatting context as well? Because Ruby containers already establishes their own formatting context, so writing a test case may be trivial.

Thanks for the thoroughness! It sounds like what you've got is probably sufficient, but I'll let you know if I notice something missing.
(Assignee)

Comment 7

10 months ago
(In reply to Daniel Holbert [:dholbert] from comment #6)
> Comment on attachment 8983602 [details]
> Bug 1465936 - Ignore contain:paint for elements without a principal box,
> internal table elements except table-cell, internal ruby elements, and
> non-atomic inlines.
> 
> https://reviewboard.mozilla.org/r/249462/#review255630
> 
> > For internal ruby elements (<rb>, <rbc>, <rt>, <rtc>), I realized <rbc> is not listed in the website anymore (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rtc). Is <rbc> in the deprecation process by any chance? The reason I'm asking is only <rbc> seems to be not working in above test for both stacking context and overflow clipping. It seems to work for containing block, though.
> 
> I'm not sure, though be aware that the real thing that matters here are the
> CSS display values. <rbc> corresponds to display:ruby-base-container, which
> is specced at https://drafts.csswg.org/css-ruby-1/#ruby-display
> 
> It looks like we do support display:ruby-base-container, e.g. we use it
> here:
> https://searchfox.org/mozilla-central/rev/
> 3737701cfab93ccea04c0e9cab211ad10f931d87/layout/style/res/ua.css#115
> 
> So I think it is something you need to consider. I'd suggest looking for
> usages in testcases, and xidorn is probably the best authority on its
> specifics.

Thanks a lot for all the information. I'll look into it and also check the test case to make sure <rbc> works.


> Thanks for the thoroughness! It sounds like what you've got is probably
> sufficient, but I'll let you know if I notice something missing.

Thanks!
Comment hidden (mozreview-request)
(Assignee)

Comment 9

10 months ago
All thanks to Daniel and Xidorn (IRC), <rbc> now works. For future reference, <rbc> does not have native support as an HTML element, however, supported as a CSS property (display:ruby-base-container).
(Assignee)

Updated

10 months ago
Priority: -- → P3

Comment 10

10 months ago
mozreview-review
Comment on attachment 8983602 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/249462/#review255938

Code looks good, I think! The tests need a bit more work, though - see below.

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-internal-table-001.html:10
(Diff revision 2)
> +    <style>
> +      tr {
> +        contain: paint;
> +        z-index: 10;
> +      }

Please create a second chunk of this testcase (or a second copy of this testcase) where you selectively test a <tbody> with contain:paint as well (which exercises the "table-row-group" internal table part).

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-internal-table-001.html:19
(Diff revision 2)
> +      caption {
> +        position: fixed;
> +        background-color: red;
> +        z-index: 2;

Please replace "red" with a different background color here -- maybe "lime" or "yellow".

red is problematic here because there's a semi-official convention in w3c tests that "red means test-failure".  Lots of tests are written such that there's a red thing and something else overlapping, and the test passes if the red thing is completely covered up.  And for now, this test here is the exact reverse of that :)  (the test passes when the read thing is on top).  So let's make it not-red.

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-no-principal-box-001.html:9
(Diff revision 2)
> +  <meta charset="utf-8">
> +  <title>CSS Test: 'contain: paint' with 'display: contents'.</title>
> +  <link rel="author" title="Yusuf Sermet" href="mailto:ysermet@mozilla.com">
> +  <link rel="help" href="https://drafts.csswg.org/css-contain/#containment-paint">
> +  <link rel="match" href="contain-paint-ignored-cases-no-principal-box-001-ref.html">
> +  <meta name="assert" content="Contain:paint shoud have no effect when no principle box is generated.">

Typo: s/shoud/should/

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-no-principal-box-001.html:50
(Diff revision 2)
> +    }
> +  </style>
> +</head>
> +<body>
> +  <div id="div1">
> +    <br/><br/>

Rather than <br/><br/>, let's just give these divs an explicit pixel-valued height here.  That's a bit cleaner and makes the outcome more predictable regardless of system font-size etc.

So e.g. I'd suggest you style #div1 with "height: 100px" for example, and get rid of its <br> children, and similar for div2_1 and div3.  (It looks like you did this for div2_2 already, which is good.)

::: layout/reftests/w3c-css/submitted/contain/reftest.list:14
(Diff revision 2)
> +== contain-paint-ignored-cases-non-atomic-inline-001.html contain-paint-ignored-cases-non-atomic-inline-001-ref.html
> +== contain-paint-ignored-cases-no-principal-box-001.html contain-paint-ignored-cases-no-principal-box-001-ref.html
> +== contain-paint-ignored-cases-ruby-containing-block-001.html contain-paint-ignored-cases-ruby-containing-block-001-ref.html
> +== contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html contain-paint-ignored-cases-ruby-stacking-and-clipping-001-ref.html
>  == contain-paint-stacking-context-001a.html contain-paint-stacking-context-001-ref.html

Hmm, 3 of these new tests fail for me, in Firefox with your patch applied (and with containment preffed on by setting layout.css.contain.enabled = true in about:config).

It looks like they fail in Chrome, too, so it's probably a bug in the test expectations rather than in the implementation.

(I tried just viewing them directly in patched Firefox as well as in Chrome, and I also tried running them in the reftest harness in Firefox with ./mach reftest layout/reftests/w3c-css/submitted/contain/ , and the testcase & reference case don't match in all of those configurations.)


These are the problematic tests:
contain-paint-ignored-cases-non-atomic-inline-001.html
contain-paint-ignored-cases-ruby-containing-block-001.html
contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html
Attachment #8983602 - Flags: review?(dholbert) → review-
(Assignee)

Comment 11

10 months ago
Thanks for all your comments! Much appreciated.

(In reply to Daniel Holbert [:dholbert] from comment #10)
> Hmm, 3 of these new tests fail for me, in Firefox with your patch applied
> (and with containment preffed on by setting layout.css.contain.enabled =
> true in about:config).
> 
> It looks like they fail in Chrome, too, so it's probably a bug in the test
> expectations rather than in the implementation.
> 
> (I tried just viewing them directly in patched Firefox as well as in Chrome,
> and I also tried running them in the reftest harness in Firefox with ./mach
> reftest layout/reftests/w3c-css/submitted/contain/ , and the testcase &
> reference case don't match in all of those configurations.)
> 
> 
> These are the problematic tests:
> contain-paint-ignored-cases-non-atomic-inline-001.html
> contain-paint-ignored-cases-ruby-containing-block-001.html
> contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html

I'll try to differentiate these issues.

*FOR Ruby-related failing tests (containing, stacking)*

For CHROME, yes, I am aware that the tests are failing in Chrome, and the reason for that I believe Chrome (as of v66) does not support ignoring contain:paint for Ruby elements. This makes sense to me, because ignoring ruby is a newer feature in the spec, just like taking rounded corners into account when doing overflow clipping. Previously, we found out that Chrome does not take that into account as well, and filed a bug (https://bugs.chromium.org/p/chromium/issues/detail?id=848793). According to schenney from chromium, its fixed on v67. So, I am thinking maybe this is a similar situation.

Another thing to note, is that the support of Ruby elements are not the same in Firefox and Chrome. (e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rtc) However, this should not create an issue, because I deliberately *tried* writing the test cases to work even if the ruby support is different, as we are not testing the correctness or completeness of the ruby, but whether ruby ignores the contain:paint.

As for why it's failing in FIREFOX, it's currently working just fine in my patched firefox locally, which may mean three things:

1) Our previous patch (https://reviewboard.mozilla.org/r/248090/diff/5#index_header) might somehow have an effect for the accuracy of this one. Because, that one hasn't been shipped yet, so you probably don't have it, but it's applied in my local copy.
-> I don't think this is the problem, because when I ran these cases in Firefox Nightly (without patches), and just remove contain:paint manually, it matches to ref, which means all we have to do is ignoring contain:paint
-> And I don't see why it should interfere with this bug.

2) New patches (since the last time I pulled) might have changed something that might be related to this bug. So, it's probably a good idea for me to update my repo, just to eliminate that possibility.

3) These test cases may be fundamentally wrong and I should look more into (i.e. learn) the usage of Ruby elements.

*FOR non-atomic inline failing test*

For CHROME, It doesn't work in Chrome as well, probably because the same reason above.

For FIREFOX, I reused the test here (https://test.csswg.org/harness/test/css-contain-1_dev/single/contain-paint-002/) to not to reinvent the wheel. It seems to work locally as well. If we are going to assume that the tests in that link are accurate, then it should be something about the implementation, meaning the options 1 and 2 above are reasonable.

So, I checked the code in the other bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1465250#c19) and realized that we removed the part where we are promoting an inline element to inline-block if it has a contain:paint. However, since that patch hasn't been landed yet, when you were testing this test case, the span element still got promoted to inline-block, in which case the contain:paint should indeed apply. So, when you ran it, the test wasn't even testing an inline element. Once both of these patches applied, this test case should work.

We decided to separate these bugs in previous comments (1,3), and I'm sorry I didn't realize they were tightly coupled.

*FOR all other comments*

I'll make sure to update accordingly!
Ah, indeed, I was testing without the other bug's patch applied. It definitely makes sense that the inline->inline-block promotion logic might've caused the failures that I was seeing (in Firefox). (If that other bug is ready to land [I think it is?], let's go ahead and get it landed! You can make that happen by adding the "checkin-needed" flag to the keywords field, in the "Tracking" section of fields at the top of the bug.)

RE Chrome testing -- I'm using Chrome "Dev Channel" v68, and it's probably worth it for you also to preferentially use that version as well (rather than 66) for testing. You can get it from https://www.chromium.org/getting-involved/dev-channel .  I can confirm that your corner-clipping testcase is indeed fixed for me in that version, for the Chrome bug that you linked. But since this bug's testcases are not fixed in that verison, they might merit a Chrome bug or two.

Thanks!
(Assignee)

Comment 13

10 months ago
There were 3 tests that are failed when we did a try run for that bug. I was planning to ask few questions how to interpret some of them in our weekly meeting, which hopefully I'll do tomorrow!

You're absolutely right, I'll switch to the Chrome Dev Channel, and file the appropriate chrome bug(s).

Thank you!
Comment hidden (mozreview-request)

Comment 15

10 months ago
mozreview-review
Comment on attachment 8983602 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/249462/#review256412

r=me with the following addressed:

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-no-principal-box-001-ref.html:20
(Diff revision 3)
> +    #div2 {
> +      display: contents;
> +      contain: paint;

Let's remove "contain:paint" from this reference case, I think.

Pretty sure that's what you intended to do, and it just got left in by mistake. Right now, the <style> and <body> of this file is actually *identical* to the testcase, aside from the metadata at the top, so it trivially passes. :)  But with contain:paint removed in this reference case, I think all will be well.

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-non-atomic-inline-001.html:1
(Diff revision 3)
> +<!DOCTYPE html>

As discussed, it seems we've already got this test in the tree at https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/css/css-contain/contain-paint-002.html (and it starts passing as of bug 1465250) -- so no need to create a new copy of it here.

So - please delete this file & its reference case from this commit, and from the reftest.list tweaks in this commit.

::: layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-ruby-containing-block-001.html:16
(Diff revision 3)
> +      rb,
> +      rbc,
> +      rt,
> +      rtc {
> +        contain: paint;
> +        background-color: red;

Let's use a different color here, rather than red, per comment 10. (Maybe yellow, for consistency with your other ruby testcase)

Right now this testcase renders mostly red, which makes it look like it might be intending to indicate failure, when really that's just the expected rendering.
Attachment #8983602 - Flags: review?(dholbert) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 17

10 months ago
mozreview-review-reply
Comment on attachment 8983602 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/249462/#review256412

> Let's remove "contain:paint" from this reference case, I think.
> 
> Pretty sure that's what you intended to do, and it just got left in by mistake. Right now, the <style> and <body> of this file is actually *identical* to the testcase, aside from the metadata at the top, so it trivially passes. :)  But with contain:paint removed in this reference case, I think all will be well.

ah, a last minute mistake when I was updating the divs.
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 18

9 months ago
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2e4bbd59dc7
Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines. r=dholbert
Keywords: checkin-needed
Backed out changeset a2e4bbd59dc7 (bug 1465936) for Web Platform test failures on css/css-contain/contain-paint-005.html

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=182899101&repo=autoland&lineNumber=7163

INFO - TEST-PASS | /css/css-contain/contain-paint-004.html | took 44ms
[task 2018-06-12T08:41:53.367Z] 08:41:53     INFO - TEST-START | /css/css-contain/contain-paint-005.html
[task 2018-06-12T08:41:53.371Z] 08:41:53     INFO - PID 5398 | 1528792913369	Marionette	INFO	Testing http://web-platform.test:8000/css/css-contain/contain-paint-005.html == http://web-platform.test:8000/css/css-contain/reference/contain-size-001-ref.html
[task 2018-06-12T08:41:53.427Z] 08:41:53     INFO - TEST-UNEXPECTED-PASS | /css/css-contain/contain-paint-005.html | Testing http://web-platform.test:8000/css/css-contain/contain-paint-005.html == http://web-platform.test:8000/css/css-contain/reference/contain-size-001-ref.html
[task 2018-06-12T08:41:53.428Z] 08:41:53     INFO - REFTEST   IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAlgAAAJYCAYAAAC+ZpjcAAAOsklEQVR4nO3d2W7bRgBAUf3/T6dPBgxXJGe5tGT7HCAoQg3JERfxWmnTxz8AAFKPV08AAOC3EVgAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQe3lgPR4vnwI3cn4B+IuGnn6Px+Py19exwxMIH8Df9TAXDeOOjtXR9cPPcnV+/6rR9z/ymVpvf2fcyhxm/PXrht9lOLB2fv9dBNbP8C7XC/vOzt1fP6+j7/8ses7WWXl99Afimciq/fXrht9DYL3xfn4rx+/3EFjHdgPr6LWPZVffSI1sc/f8CSw4tnQlj3x9/fHPs6+cr5avfF19tl7xVfns1/mfX59dZ/cr/dU/Hljd39E6q9t5Nmb13O7+pD66n9m5zB7To33snNvVeVzdC3dc90fjvy4fGTeyz9Fz9ey1meM489qzYzyzzZVxV+vXn22z6xbXAtRuC6yjC/tqWzsPwZ0Pqpl9z96co+/9aE4r89x5L3efk9mQWJ3f6H5XH0YzH+jPtjU6dmS+q+d2ZtnoXK7mVM6hfo8rx3bn/jha/+i1kfv8apsr487W/65zcLWsvrZh122BNbp8NF52Amv0A2x0/ZXAWnltdv+z76U+LqNjysCafTiN7mN0TH0MqrnsntvduZy9NnM/zX7WfPx+JHxntzk7v93IKX5wGAm90XGjc3z22s7xXt3H6LUAd3nLwFq9AYrA2n2o7Ox/dMzMh2Yxr/qc7By/Ox6Ud5zzq3V351Ke25Vt7KwvsP4/7tmv0W3OXDN1bAksOPZ2gfWxbOWnqpGf5K4+yFY/5Fbm9ey10Q/b0XnObGP3uIy8v6Nlo9t498CaOX/lfkbn8XX8zDUwO9+ZwCrmcHSdzF6DO9fY6GvluNn7cfSYlud/9rNmZR+ffz9zLcBd3jKwno3Zudl3bqqRD4DVeX19bTcARs5L9WGzc05Wj99dD8oqsIrrfvWcrJ7b3QdOFVjFHEYetiP7fOfA2gnRO+a1+9k2ss3dwDpbDnd6u8C64yFYB86rA2tk3M6Y1XmNjln5kDt6iLw6sFaP06vmsjpuZUxxP83M4S8E1uhr73b+d+YusPip3jKwVh/KZzdmue/Z4JrZ7uqyr9tbfS+j8zpad2RMGVgz+5g5liP7qc7VyPKVbc4cl5V5XO2zOF+jVo5nNY/Ra21m/d0xZ9fIyrizfdbX2e55mb3uRBd3mb6yPi7Is4v47EHz7OY+Gzt7A5ytM7LN0X3PzO1jzMr+Py+bnefKe9k9LkfrzOzraFuj+7p6qI4c39X9jGx/5h4ZncfOuZ0Zd7Xu1XvZvT/P5jCzfHSfd19Xs9ueGbN6jczeC8+2MTLPq+M9u+7ncaPLV641GOXK+gZu4H2OIQA/iafWNxAHaz7/dAwAP4kn181W/8gDxw6An8uTCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGJDgfV4PA5/jay3sv2dcQAArzRcKGfRc7bOyutfl4+OAwB4B9uBdfTax7Krb6RGtjm7bwCAV7o9sM7WHY0jEQUA/CS3BNazP+Kb3ebKOACAd3DLv4M1uuxj+cy/MC+2AIB3NxVYM/+138iys30U4wAAXiH5I8KRcTMxNPvXOwAAvJNbAmv1781a3R8AwDv5tm+wnr3mr2kAAH6jNLBmx/iLRgGA32j6f5VTj/G/yQEAfhuVAgAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAALH/AKKNFtEKwIJKAAAAAElFTkSuQmCC
[task 2018-06-12T08:41:53.428Z] 08:41:53     INFO - REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAlgAAAJYCAYAAAC+ZpjcAAAOsklEQVR4nO3d2W7bRgBAUf3/T6dPBgxXJGe5tGT7HCAoQg3JERfxWmnTxz8AAFKPV08AAOC3EVgAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQe3lgPR4vnwI3cn4B+IuGnn6Px+Py19exwxMIH8Df9TAXDeOOjtXR9cPPcnV+/6rR9z/ymVpvf2fcyhxm/PXrht9lOLB2fv9dBNbP8C7XC/vOzt1fP6+j7/8ses7WWXl99Afimciq/fXrht9DYL3xfn4rx+/3EFjHdgPr6LWPZVffSI1sc/f8CSw4tnQlj3x9/fHPs6+cr5avfF19tl7xVfns1/mfX59dZ/cr/dU/Hljd39E6q9t5Nmb13O7+pD66n9m5zB7To33snNvVeVzdC3dc90fjvy4fGTeyz9Fz9ey1meM489qzYzyzzZVxV+vXn22z6xbXAtRuC6yjC/tqWzsPwZ0Pqpl9z96co+/9aE4r89x5L3efk9mQWJ3f6H5XH0YzH+jPtjU6dmS+q+d2ZtnoXK7mVM6hfo8rx3bn/jha/+i1kfv8apsr487W/65zcLWsvrZh122BNbp8NF52Amv0A2x0/ZXAWnltdv+z76U+LqNjysCafTiN7mN0TH0MqrnsntvduZy9NnM/zX7WfPx+JHxntzk7v93IKX5wGAm90XGjc3z22s7xXt3H6LUAd3nLwFq9AYrA2n2o7Ox/dMzMh2Yxr/qc7By/Ox6Ud5zzq3V351Ke25Vt7KwvsP4/7tmv0W3OXDN1bAksOPZ2gfWxbOWnqpGf5K4+yFY/5Fbm9ey10Q/b0XnObGP3uIy8v6Nlo9t498CaOX/lfkbn8XX8zDUwO9+ZwCrmcHSdzF6DO9fY6GvluNn7cfSYlud/9rNmZR+ffz9zLcBd3jKwno3Zudl3bqqRD4DVeX19bTcARs5L9WGzc05Wj99dD8oqsIrrfvWcrJ7b3QdOFVjFHEYetiP7fOfA2gnRO+a1+9k2ss3dwDpbDnd6u8C64yFYB86rA2tk3M6Y1XmNjln5kDt6iLw6sFaP06vmsjpuZUxxP83M4S8E1uhr73b+d+YusPip3jKwVh/KZzdmue/Z4JrZ7uqyr9tbfS+j8zpad2RMGVgz+5g5liP7qc7VyPKVbc4cl5V5XO2zOF+jVo5nNY/Ra21m/d0xZ9fIyrizfdbX2e55mb3uRBd3mb6yPi7Is4v47EHz7OY+Gzt7A5ytM7LN0X3PzO1jzMr+Py+bnefKe9k9LkfrzOzraFuj+7p6qI4c39X9jGx/5h4ZncfOuZ0Zd7Xu1XvZvT/P5jCzfHSfd19Xs9ueGbN6jczeC8+2MTLPq+M9u+7ncaPLV641GOXK+gZu4H2OIQA/iafWNxAHaz7/dAwAP4kn181W/8gDxw6An8uTCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGJDgfV4PA5/jay3sv2dcQAArzRcKGfRc7bOyutfl4+OAwB4B9uBdfTax7Krb6RGtjm7bwCAV7o9sM7WHY0jEQUA/CS3BNazP+Kb3ebKOACAd3DLv4M1uuxj+cy/MC+2AIB3NxVYM/+138iys30U4wAAXiH5I8KRcTMxNPvXOwAAvJNbAmv1781a3R8AwDv5tm+wnr3mr2kAAH6jNLBmx/iLRgGA32j6f5VTj/G/yQEAfhuVAgAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAALH/AKKNFtEKwIJKAAAAAElFTkSuQmCC
[task 2018-06-12T08:41:53.428Z] 08:41:53     INFO - TEST-INFO expected FAIL | took 52ms
[task 2018-06-12T08:41:53.452Z] 08:41:53     INFO - PID 5398 | 1528792913446	Marionette	INFO	Stopped listening on port 2828
[task 2018-06-12T08:41:53.892Z] 08:41:53     INFO - Browser exited with return code 0
[task 2018-06-12T08:41:53.893Z] 08:41:53  WARNING - u'runner_teardown': ()
[task 2018-06-12T08:41:53.901Z] 08:41:53     INFO - Setting up ssl
[task 2018-06-12T08:41:53.937Z] 08:41:53     INFO - certutil | 
[task 2018-06-12T08:41:53.965Z] 08:41:53     INFO - certutil | 
[task 2018-06-12T08:41:53.986Z] 08:41:53     INFO - certutil | 
[task 2018-06-12T08:41:53.986Z] 08:41:53     INFO - Certificate Nickname                                         Trust Attributes
[task 2018-06-12T08:41:53.986Z] 08:41:53     INFO -                                                              SSL,S/MIME,JAR/XPI
[task 2018-06-12T08:41:53.986Z] 08:41:53     INFO - 
[task 2018-06-12T08:41:53.986Z] 08:41:53     INFO - web-platform-tests                                           CT,, 
[task 2018-06-12T08:41:53.987Z] 08:41:53     INFO - 
[task 2018-06-12T08:41:54.003Z] 08:41:54     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpQdgyVg.mozrunner
[task 2018-06-12T08:41:54.019Z] 08:41:54     INFO - Starting runner
[task 2018-06-12T08:41:56.032Z] 08:41:56     INFO - PID 5584 | 1528792916019	Marionette	INFO	Listening on port 2828
[task 2018-06-12T08:41:56.219Z] 08:41:56     INFO - TEST-START | /css/css-contain/contain-paint-006.html
[task 2018-06-12T08:41:56.602Z] 08:41:56     INFO - PID 5584 | 1528792916599	Marionette	INFO	Testing http://web-platform.test:8000/css/css-contain/contain-paint-006.html == http://web-platform.test:8000/css/css-contain/reference/contain-size-001-ref.html
[task 2018-06-12T08:41:56.694Z] 08:41:56     INFO - TEST-UNEXPECTED-PASS | /css/css-contain/contain-paint-006.html | Testing http://web-platform.test:8000/css/css-contain/contain-paint-006.html == http://web-platform.test:8000/css/css-contain/reference/contain-size-001-ref.html
[task 2018-06-12T08:41:56.694Z] 08:41:56     INFO - REFTEST   IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAlgAAAJYCAYAAAC+ZpjcAAAOsklEQVR4nO3d2W7bRgBAUf3/T6dPBgxXJGe5tGT7HCAoQg3JERfxWmnTxz8AAFKPV08AAOC3EVgAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQe3lgPR4vnwI3cn4B+IuGnn6Px+Py19exwxMIH8Df9TAXDeOOjtXR9cPPcnV+/6rR9z/ymVpvf2fcyhxm/PXrht9lOLB2fv9dBNbP8C7XC/vOzt1fP6+j7/8ses7WWXl99Afimciq/fXrht9DYL3xfn4rx+/3EFjHdgPr6LWPZVffSI1sc/f8CSw4tnQlj3x9/fHPs6+cr5avfF19tl7xVfns1/mfX59dZ/cr/dU/Hljd39E6q9t5Nmb13O7+pD66n9m5zB7To33snNvVeVzdC3dc90fjvy4fGTeyz9Fz9ey1meM489qzYzyzzZVxV+vXn22z6xbXAtRuC6yjC/tqWzsPwZ0Pqpl9z96co+/9aE4r89x5L3efk9mQWJ3f6H5XH0YzH+jPtjU6dmS+q+d2ZtnoXK7mVM6hfo8rx3bn/jha/+i1kfv8apsr487W/65zcLWsvrZh122BNbp8NF52Amv0A2x0/ZXAWnltdv+z76U+LqNjysCafTiN7mN0TH0MqrnsntvduZy9NnM/zX7WfPx+JHxntzk7v93IKX5wGAm90XGjc3z22s7xXt3H6LUAd3nLwFq9AYrA2n2o7Ox/dMzMh2Yxr/qc7By/Ox6Ud5zzq3V351Ke25Vt7KwvsP4/7tmv0W3OXDN1bAksOPZ2gfWxbOWnqpGf5K4+yFY/5Fbm9ey10Q/b0XnObGP3uIy8v6Nlo9t498CaOX/lfkbn8XX8zDUwO9+ZwCrmcHSdzF6DO9fY6GvluNn7cfSYlud/9rNmZR+ffz9zLcBd3jKwno3Zudl3bqqRD4DVeX19bTcARs5L9WGzc05Wj99dD8oqsIrrfvWcrJ7b3QdOFVjFHEYetiP7fOfA2gnRO+a1+9k2ss3dwDpbDnd6u8C64yFYB86rA2tk3M6Y1XmNjln5kDt6iLw6sFaP06vmsjpuZUxxP83M4S8E1uhr73b+d+YusPip3jKwVh/KZzdmue/Z4JrZ7uqyr9tbfS+j8zpad2RMGVgz+5g5liP7qc7VyPKVbc4cl5V5XO2zOF+jVo5nNY/Ra21m/d0xZ9fIyrizfdbX2e55mb3uRBd3mb6yPi7Is4v47EHz7OY+Gzt7A5ytM7LN0X3PzO1jzMr+Py+bnefKe9k9LkfrzOzraFuj+7p6qI4c39X9jGx/5h4ZncfOuZ0Zd7Xu1XvZvT/P5jCzfHSfd19Xs9ueGbN6jczeC8+2MTLPq+M9u+7ncaPLV641GOXK+gZu4H2OIQA/iafWNxAHaz7/dAwAP4kn181W/8gDxw6An8uTCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGJDgfV4PA5/jay3sv2dcQAArzRcKGfRc7bOyutfl4+OAwB4B9uBdfTax7Krb6RGtjm7bwCAV7o9sM7WHY0jEQUA/CS3BNazP+Kb3ebKOACAd3DLv4M1uuxj+cy/MC+2AIB3NxVYM/+138iys30U4wAAXiH5I8KRcTMxNPvXOwAAvJNbAmv1781a3R8AwDv5tm+wnr3mr2kAAH6jNLBmx/iLRgGA32j6f5VTj/G/yQEAfhuVAgAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAALH/AKKNFtEKwIJKAAAAAElFTkSuQmCC
[task 2018-06-12T08:41:56.695Z] 08:41:56     INFO - REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAlgAAAJYCAYAAAC+ZpjcAAAOsklEQVR4nO3d2W7bRgBAUf3/T6dPBgxXJGe5tGT7HCAoQg3JERfxWmnTxz8AAFKPV08AAOC3EVgAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQe3lgPR4vnwI3cn4B+IuGnn6Px+Py19exwxMIH8Df9TAXDeOOjtXR9cPPcnV+/6rR9z/ymVpvf2fcyhxm/PXrht9lOLB2fv9dBNbP8C7XC/vOzt1fP6+j7/8ses7WWXl99Afimciq/fXrht9DYL3xfn4rx+/3EFjHdgPr6LWPZVffSI1sc/f8CSw4tnQlj3x9/fHPs6+cr5avfF19tl7xVfns1/mfX59dZ/cr/dU/Hljd39E6q9t5Nmb13O7+pD66n9m5zB7To33snNvVeVzdC3dc90fjvy4fGTeyz9Fz9ey1meM489qzYzyzzZVxV+vXn22z6xbXAtRuC6yjC/tqWzsPwZ0Pqpl9z96co+/9aE4r89x5L3efk9mQWJ3f6H5XH0YzH+jPtjU6dmS+q+d2ZtnoXK7mVM6hfo8rx3bn/jha/+i1kfv8apsr487W/65zcLWsvrZh122BNbp8NF52Amv0A2x0/ZXAWnltdv+z76U+LqNjysCafTiN7mN0TH0MqrnsntvduZy9NnM/zX7WfPx+JHxntzk7v93IKX5wGAm90XGjc3z22s7xXt3H6LUAd3nLwFq9AYrA2n2o7Ox/dMzMh2Yxr/qc7By/Ox6Ud5zzq3V351Ke25Vt7KwvsP4/7tmv0W3OXDN1bAksOPZ2gfWxbOWnqpGf5K4+yFY/5Fbm9ey10Q/b0XnObGP3uIy8v6Nlo9t498CaOX/lfkbn8XX8zDUwO9+ZwCrmcHSdzF6DO9fY6GvluNn7cfSYlud/9rNmZR+ffz9zLcBd3jKwno3Zudl3bqqRD4DVeX19bTcARs5L9WGzc05Wj99dD8oqsIrrfvWcrJ7b3QdOFVjFHEYetiP7fOfA2gnRO+a1+9k2ss3dwDpbDnd6u8C64yFYB86rA2tk3M6Y1XmNjln5kDt6iLw6sFaP06vmsjpuZUxxP83M4S8E1uhr73b+d+YusPip3jKwVh/KZzdmue/Z4JrZ7uqyr9tbfS+j8zpad2RMGVgz+5g5liP7qc7VyPKVbc4cl5V5XO2zOF+jVo5nNY/Ra21m/d0xZ9fIyrizfdbX2e55mb3uRBd3mb6yPi7Is4v47EHz7OY+Gzt7A5ytM7LN0X3PzO1jzMr+Py+bnefKe9k9LkfrzOzraFuj+7p6qI4c39X9jGx/5h4ZncfOuZ0Zd7Xu1XvZvT/P5jCzfHSfd19Xs9ueGbN6jczeC8+2MTLPq+M9u+7ncaPLV641GOXK+gZu4H2OIQA/iafWNxAHaz7/dAwAP4kn181W/8gDxw6An8uTCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGJDgfV4PA5/jay3sv2dcQAArzRcKGfRc7bOyutfl4+OAwB4B9uBdfTax7Krb6RGtjm7bwCAV7o9sM7WHY0jEQUA/CS3BNazP+Kb3ebKOACAd3DLv4M1uuxj+cy/MC+2AIB3NxVYM/+138iys30U4wAAXiH5I8KRcTMxNPvXOwAAvJNbAmv1781a3R8AwDv5tm+wnr3mr2kAAH6jNLBmx/iLRgGA32j6f5VTj/G/yQEAfhuVAgAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAADGBBQAQE1gAALH/AKKNFtEKwIJKAAAAAElFTkSuQmCC
[task 2018-06-12T08:41:56.695Z] 08:41:56     INFO - TEST-INFO expected FAIL | took 469ms
[task 2018-06-12T08:41:56.719Z] 08:41:56     INFO - PID 5584 | 1528792916715	Marionette	INFO	Stopped listening on port 2828
[task 2018-06-12T08:41:57.158Z] 08:41:57     INFO - Browser exited with return code 0
[task 2018-06-12T08:41:57.159Z] 08:41:57  WARNING - u'runner_teardown': ()
[task 2018-06-12T08:41:57.168Z] 08:41:57     INFO - Setting up ssl
[task 2018-06-12T08:41:57.196Z] 08:41:57     INFO - certutil | 
[task 2018-06-12T08:41:57.232Z] 08:41:57     INFO - certutil | 
[task 2018-06-12T08:41:57.253Z] 08:41:57     INFO - certutil | 
[task 2018-06-12T08:41:57.253Z] 08:41:57     INFO - Certificate Nickname                                         Trust Attributes
[task 2018-06-12T08:41:57.253Z] 08:41:57     INFO -                                                              SSL,S/MIME,JAR/XPI
[task 2018-06-12T08:41:57.253Z] 08:41:57     INFO - 
[task 2018-06-12T08:41:57.254Z] 08:41:57     INFO - web-platform-tests                                           CT,, 
[task 2018-06-12T08:41:57.254Z] 08:41:57     INFO - 
[task 2018-06-12T08:41:57.263Z] 08:41:57     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpcGAw1y.mozrunner
[task 2018-06-12T08:41:57.279Z] 08:41:57     INFO - Starting runner
[task 2018-06-12T08:41:59.261Z] 08:41:59     INFO - PID 5745 | 1528792919249	Marionette	INFO	Listening on port 2828

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a2e4bbd59dc74db9f12815ce2cec3aff21fd5cca&filter-searchStr=Linux%20opt%20Web%20platform%20tests%20with%20e10s%20test-linux32%2Fopt-web-platform-tests-reftests-e10s-5%20W-e10s(Wr5)

Backout:
https://hg.mozilla.org/integration/autoland/rev/fc4a67d2aea5879d93232c5639e6d806c9c923f8
Flags: needinfo?(ysermet)
Looks like those are all TEST-UNEXPECTED-PASS.  Hooray!

I think that means we just need to do "hg rm" for seven of the .ini files here:
 https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/css/css-contain
(Assignee)

Updated

9 months ago
Attachment #8983602 - Attachment is obsolete: true
(Assignee)

Comment 23

9 months ago
(In reply to Daniel Holbert [:dholbert] from comment #21)
> specifically, you want to remove the .ini files for each of the 7 tests

Thanks! Removed and submitted for review.
Flags: needinfo?(ysermet)

Comment 24

9 months ago
mozreview-review
Comment on attachment 8985408 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/251044/#review257264

::: layout/style/nsStyleStruct.h:2376
(Diff revision 1)
>    bool IsInnerTableStyle() const {
>      return mozilla::StyleDisplay::TableCaption == mDisplay ||
>             mozilla::StyleDisplay::TableCell == mDisplay ||
> -           mozilla::StyleDisplay::TableRow == mDisplay ||
> +           IsInternalTableStyleExceptCell();
> +
> +  bool IsInternalTableStyleExceptCell() const {

Looks like you're missing a closing curly-brace here  (to end the implementation of IsInnerTableStyle()).

::: layout/style/nsStyleStruct.h:2408
(Diff revision 1)
>    static bool IsRubyDisplayType(mozilla::StyleDisplay aDisplay) {
>      return mozilla::StyleDisplay::Ruby == aDisplay ||
> -           mozilla::StyleDisplay::RubyBase == aDisplay ||
> +           IsInternalRubyDisplayType(aDisplay);
> +
> +  static bool IsInternalRubyDisplayType(mozilla::StyleDisplay aDisplay) {

Here too.
(With that fixed, this looks good, assuming it passes Try!  Looks like it's the same as previously-landed commit, plus the .ini removals.)
Comment hidden (mozreview-request)

Comment 27

9 months ago
mozreview-review
Comment on attachment 8985408 [details]
Bug 1465936 - Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines.

https://reviewboard.mozilla.org/r/251044/#review257294

Looks good! Hopefully the try results come back green.
Attachment #8985408 - Flags: review?(dholbert) → review+
(Assignee)

Comment 28

9 months ago
There were quite a few errors or warnings for the try run. I tried reviewing all of them, and it seems like they are all unrelated to this patch.
(Assignee)

Updated

9 months ago
Keywords: checkin-needed
Agreed - all of the oranges on the Try run (as of now) look unrelated to me.

Comment 30

9 months ago
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ad07da6e0db
Ignore contain:paint for elements without a principal box, internal table elements except table-cell, internal ruby elements, and non-atomic inlines. r=dholbert
Keywords: checkin-needed

Comment 31

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0ad07da6e0db
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62

Comment 33

9 months ago
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74c53ad34b8a
Follow-up: Fix reftests to have LF line endings and to end with a newline. r=dholbert
Thanks - landed a patch from Yusuf to fix that.
Flags: needinfo?(ysermet)
Flags: needinfo?(dholbert)
(Assignee)

Updated

9 months ago
Blocks: 1471452
You need to log in before you can comment on or make changes to this bug.