1465953 - Create an about:policies page

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P2)

Description

[:Felipe Gomes (needinfo for replies!)]

This bug tracks the actual implementation of an about:policies page that will display all the policies that are currently active.

Comment 1

[Kanika Saini]

Attachment: Bug 1465953 - about:policies URL linked to aboutPolicies.xhtml

Review commit: https://reviewboard.mozilla.org/r/253104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253104/

Comment 2

[Kanika Saini]

Comment on attachment 8987817 [details]
Bug 1465953 - about:policies URL linked to aboutPolicies.xhtml

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253104/diff/1-2/

Comment 3

[Kanika Saini]

Oh apologies, I saw that even after the full build, about:policies URL is not displaying the aboutPolicies.XHTML file the way I expected it to work.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Ok, I forgot about the browser/components/build/nsModule.cpp part. I tested your patch on my machine and that was the only thing missing. After I added it, about:policies started working.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Hi Kanika, I saw on the screenshot from the other bug that you're still using the chrome:// URL for the page, so I just wanted to make sure that you saw the comment 4 here.

When you add that to the patch I'll review and land it, and then you should be able to use artifact builds again to work on bug 1472528

Comment 6

[Kanika Saini]

Comment on attachment 8987817 [details]
Bug 1465953 - about:policies URL linked to aboutPolicies.xhtml

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253104/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a21149d9d236
Create the basic structure for an about:policies page. r=felipe

Comment 8

[Cristina Coroiu [:ccoroiu]]

Backed out changeset a21149d9d236 (bug 1465953) for browser-chrome failures at browser/base/content/test/static/browser_all_files_referenced.js 

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/076cd88872e7d0a7fd3393da8ee7ff315f35933a

Failure push: 
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a21149d9d236696ce32fe55e51c7673021553c57

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=186490946&repo=mozilla-inbound&lineNumber=2668

12:54:57     INFO - TEST-START | browser/base/content/test/static/browser_all_files_referenced.js
12:54:58     INFO - GECKO(2051) | 2018-07-04 12:54:58.514 plugin-container[2054:15788] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x8c53, name = 'com.apple.tsm.portname'
12:54:58     INFO - GECKO(2051) | See /usr/include/servers/bootstrap_defs.h for the error codes.
12:55:02     INFO - GECKO(2051) | 2018-07-04 12:55:02.772 plugin-container[2055:15965] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x923f, name = 'com.apple.tsm.portname'
12:55:02     INFO - GECKO(2051) | See /usr/include/servers/bootstrap_defs.h for the error codes.
12:55:09     INFO - TEST-INFO | started process screencapture
12:55:09     INFO - TEST-INFO | screencapture: exit 0
12:55:09     INFO - Buffered messages logged at 12:54:57
12:55:09     INFO - Entering test bound checkAllTheFiles
12:55:09     INFO - Buffered messages logged at 12:55:02
12:55:09     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/FileUtils.jsm" line: 170}]
12:55:09     INFO - Buffered messages logged at 12:55:09
12:55:09     INFO - indirectly whitelisted file: chrome://marionette/content/test_dialog.dtd used from chrome://marionette/content/test_dialog.xul
12:55:09     INFO - indirectly whitelisted file: chrome://global-platform/locale/intl.properties used from resource://gre/greprefs.js
12:55:09     INFO - indirectly whitelisted file: chrome://marionette/content/test.xul used from chrome://marionette/content/test_anonymous_content.xul
12:55:09     INFO - indirectly whitelisted file: chrome://marionette/content/test_nested_iframe.xul used from chrome://marionette/content/test.xul
12:55:09     INFO - indirectly whitelisted file: chrome://marionette/content/test2.xul used from chrome://marionette/content/test.xul,chrome://marionette/content/test_nested_iframe.xul
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/addonutils.js used from resource://services-sync/engines/addons.js
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/Promise-backend.js used from resource://gre/modules/Promise.jsm,resource://devtools/shared/worker/loader.js,resource://devtools/shared/Loader.jsm
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/engines/clients.js used from resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: chrome://pippki/content/resetpassword.js used from chrome://pippki/content/resetpassword.xul
12:55:09     INFO - indirectly whitelisted file: chrome://global/content/accessibility/content-script.js used from resource://gre/modules/accessibility/AccessFu.jsm
12:55:09     INFO - indirectly whitelisted file: chrome://global/content/remote-test-ipc.js used from chrome://global/content/test-ipc.xul
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/telemetry.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/stages/enginesync.js used from resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/addonsreconciler.js used from resource://services-sync/engines/addons.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/collection_validator.js used from resource://services-sync/engines/addons.js,resource://services-sync/engines/forms.js,resource://services-sync/engines/passwords.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/policies.js used from resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/bookmark_validator.js used from resource://services-sync/engines/bookmarks.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/browserid_identity.js used from resource://services-sync/telemetry.js,resource://services-sync/status.js
12:55:09     INFO - indirectly whitelisted file: resource://services-common/tokenserverclient.js used from resource://services-sync/browserid_identity.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/status.js used from resource://services-sync/telemetry.js,resource://services-sync/policies.js,resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/collection_repair.js used from resource://services-sync/engines/clients.js,resource://services-sync/bookmark_repair.js,resource://services-sync/doctor.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/stages/declined.js used from resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: chrome://pippki/content/load_device.js used from chrome://pippki/content/load_device.xul
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/engines.js used from resource://services-sync/engines/clients.js,resource://services-sync/engines/addons.js,resource://services-sync/engines/forms.js,resource://services-sync/engines/history.js,resource://services-sync/engines/tabs.js,resource://services-sync/engines/bookmarks.js,resource://services-sync/engines/extension-storage.js,resource://services-sync/engines/passwords.js,resource://services-sync/engines/prefs.js,resource://services-sync/service.js,resource://formautofill/FormAutofillSync.jsm
12:55:09     INFO - indirectly whitelisted file: resource://services-common/logmanager.js used from resource://services-sync/policies.js
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/EventManager.jsm used from chrome://global/content/accessibility/content-script.js
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Utils.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/Traversal.jsm,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/Presentation.jsm,resource://gre/modules/accessibility/AccessFu.jsm,resource://gre/modules/accessibility/OutputGenerator.jsm,resource://gre/modules/accessibility/ContentControl.jsm
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/SyncedBookmarksMirror.jsm used from resource://services-sync/engines/bookmarks.js
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Presentation.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/AccessFu.jsm,resource://gre/modules/accessibility/ContentControl.jsm
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/OutputGenerator.jsm used from resource://gre/modules/accessibility/Presentation.jsm
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Constants.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/Traversal.jsm,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/Utils.jsm,resource://gre/modules/accessibility/Presentation.jsm,resource://gre/modules/accessibility/OutputGenerator.jsm,resource://gre/modules/accessibility/ContentControl.jsm
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/ContentControl.jsm used from chrome://global/content/accessibility/content-script.js
12:55:09     INFO - indirectly whitelisted file: chrome://passwordmgr/content/recipes.json used from resource://gre/greprefs.js
12:55:09     INFO - indirectly whitelisted file: resource://formautofill/FormAutofillSync.jsm used from resource://services-sync/service.js
12:55:09     INFO - indirectly whitelisted file: chrome://global/locale/AccessFu.properties used from resource://gre/modules/accessibility/Utils.jsm
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/bookmark_repair.js used from resource://services-sync/collection_repair.js
12:55:09     INFO - indirectly whitelisted file: resource://services-sync/doctor.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/stages/enginesync.js
12:55:09     INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Traversal.jsm used from resource://gre/modules/accessibility/ContentControl.jsm
12:55:09     INFO - Buffered messages finished
12:55:09     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 2, expected 0
12:55:09     INFO - Stack trace:
12:55:09     INFO - chrome://mochikit/content/browser-test.js:test_is:1300
12:55:09     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:684
12:55:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
12:55:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
12:55:09     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991
12:55:09     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
12:55:09     INFO - Not taking screenshot here: see the one that was previously logged
12:55:09     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/content/aboutPolicies.css - 
12:55:09     INFO - Stack trace:
12:55:09     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:688
12:55:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
12:55:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
12:55:09     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991
12:55:09     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
12:55:09     INFO - Not taking screenshot here: see the one that was previously logged
12:55:09     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/content/aboutPolicies.js - 
12:55:09     INFO - Stack trace:
12:55:09     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:688
12:55:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
12:55:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
12:55:09     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f347e524288
Create the basic structure for an about:policies page. r=felipe

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1f347e524288

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Talked with mkaply and this can ride with 63.

Comment 12

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 63.0b5 (BuildId:20180910132416) and Firefox 64.0a1 (BuildId:20180914100156) on Windows 10 64bit, Ubuntu 16.04 64bit and macOS 10.13.6.