Closed
Bug 1465968
Opened 7 years ago
Closed 7 years ago
L10N: App Share Extension 'Send to Device' not translated
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | ? | --- |
People
(Reporter: garvan, Assigned: garvan)
Details
Attachments
(2 files, 1 obsolete file)
Translation working with L10N script changed
See screenshot from user: https://pbs.twimg.com/media/Dec2K37VQAACZjk.jpg
It appears the entire dialog is translated except for the last row.
|
||
Comment 2•7 years ago
|
||
Checked on French and Italian and it seems that 'Send to Device' is not translated.
Flags: needinfo?(simion.basca)
Creating a reference to an existing string in Stings.swift angers the L10N gods. Removed the reference as a sacrifice.
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8983841 [details] [review]
Pull request
Sure. I guess. ¯\_(ツ)_/¯
Attachment #8983841 -
Flags: review?(jdarcangelo) → review+
Attachment #8983841 -
Attachment is obsolete: true
Attachment #8983841 -
Flags: review+
Comment on attachment 8983851 [details] [review]
Pull request
Reviewed this with Stefan and verified manually.
Attachment #8983851 -
Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
BTW, this fix is a change the the L10N scripts repo, not in Firefox iOS repo, next C.I. build should pick up the fixed script.
You need to log in
before you can comment on or make changes to this bug.
Description
•