1466098 - Some test defaults are set twice

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Marco Castelluccio [:marco]]

E.g. "run-on-projects" at https://dxr.mozilla.org/mozilla-central/rev/763f30c3421233a45ef9e67a695c5c241a2c8a3a/taskcluster/taskgraph/transforms/tests.py#429 and https://dxr.mozilla.org/mozilla-central/rev/763f30c3421233a45ef9e67a695c5c241a2c8a3a/taskcluster/taskgraph/transforms/tests.py#434.

Comment 1

[Bhavesh]

I would like to work on this as my first contribution. Can you please guide me where I can edit this file and where I can submit the changes?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Hi!  This will make a good practice bug for contributing a patch to the Firefox source code.

Marco has pointed to the file in his comment.  There are a few guides to getting started contributing to Firefox, such as
  https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
note that for this particular bug, there's no need to build Firefox (although it doesn't hurt).  You can test your changes by running ./mach taskgraph full -- if that runs without error, it's probably OK.

I hope that helps!

Comment 3

[Bhavesh]

Thanks a lot! I have started building Firefox, though it will take some time(my internet connection at the moment is slow) and I will make the changes as soon as possible.

Comment 4

[Bhavesh]

Attachment: bug1466098patch

Removed test defaults set twice

Comment 5

[Bhavesh]

Comment on attachment 8985056 [details] [diff] [review]
bug1466098patch

Review of attachment 8985056 [details] [diff] [review]:
-----------------------------------------------------------------

I forgot to mark it for review.

Comment 6

[Bhavesh]

Attachment: test-defaults-removed

Removed max-run-time test default removed twice too.

Comment 7

[Marco Castelluccio [:marco]]

Comment on attachment 8985302 [details] [diff] [review]
test-defaults-removed

Review of attachment 8985302 [details] [diff] [review]:
-----------------------------------------------------------------

Both patches look good, but could you remove the `instance-size` duplicate too and squash the patches into a single one?

The commit message should be changed too, it should be in the format "Bug BUG_NUMBER - DESCRIPTION OF CHANGES. r=REVIEWER". So in this case "Bug 1466098 - Remove test defaults that are set twice. r=marco".

Comment 8

[Bhavesh]

Attachment: bug1466098patch

Removed instance-size test default.
Merged all patches into one.

Comment 9

[Marco Castelluccio [:marco]]

Comment on attachment 8985313 [details] [diff] [review]
bug1466098patch

Review of attachment 8985313 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Bhavesh]

(In reply to Marco Castelluccio [:marco] from comment #9)
> Comment on attachment 8985313 [details] [diff] [review]
> bug1466098patch
> 
> Review of attachment 8985313 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks!

Thanks to you too for helping me out!

Comment 11

[Bhavesh]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #2)
> Hi!  This will make a good practice bug for contributing a patch to the
> Firefox source code.
> 
> Marco has pointed to the file in his comment.  There are a few guides to
> getting started contributing to Firefox, such as
>  
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
> note that for this particular bug, there's no need to build Firefox
> (although it doesn't hurt).  You can test your changes by running ./mach
> taskgraph full -- if that runs without error, it's probably OK.
> 
> I hope that helps!

Thanks a lot for helping me out!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66ad37417e47
Removed test defaults that are set twice. r=marco

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/66ad37417e47