1466131 - gnome shell dark theme input unreadable, even with unstyled input

Status: RESOLVED DUPLICATE of bug 1527048

(Core :: Widget: Gtk, defect)

Description

[jljatone]

Attachment: test.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180518073241

Steps to reproduce:

gnome-shell --version
GNOME Shell 3.28.2

switch to adwaita dark theme.

open firefox.

open test.html file using browser.

type into provided text field.


Actual results:

unreadable text: white on white.


Expected results:

text should have been readable. (black on white)

Comment 1

[jljatone]

I'm aware this has been a long outstand issue with firefox, and the separation of the content from the chrome was suppose to resolve the issues. and indeed the behaviour has changed.

unfortunately it still unresults in unreadable input fields. now instead of black on black you get white on white.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Hey jljatone,

There have been a lot of theme issues reported that sound similar to this one. I'm setting a component to involve the development team.

Comment 3

[romgrk.cc]

I get this issue frequently: https://image.ibb.co/dLOJ1p/Screenshot_from_2018_09_24_11_47_43.png

Comment 4

[Redsandro]

I have a LONG running argument with my friend. He's a Firefox fan and I'm, well, pretty much annoyed within the first 10 seconds of using Firefox.

My biggest and oldest unfixed annoyance is these darn unreadable input fields. After our 453rd discussion about Firefox, he told me to sign up and report a bug. 

And then I found this bug. It's only 5 months old. This issue has been there YEARS though. The same was there in Linux Mint 18 (AKA Ubuntu 16.04 LTS). And also in Mint 17.

The complete lack of interest/triaging/confirmation makes it seem likely that literally all dark theme Linux users have given up on Firefox in the past.

Come on devs, you can't honestly have this type of bug. You're losing many potential users. There is discussion about making Mint-Y-Dark the default theme.

Problem: https://i.imgur.com/jzwhyaj.png
Firefox 62.0.3 (64-bit)
Linux Mint 19 (AKA Ubuntu 18.04) with Mint-Y-Dark theme.

Comment 5

[Emmy]

I can confirm that this is a problem in 62–64.

If color or background-color alone are styled by a web page, there's a chance of ending up with unreadable text, since <input> elements take the style of the active GTK theme first and the page style second. Most devs probably (reasonably) expect the default text input element to be dark text on a light background, so adding 'background-color:#ffa' to an element results in light text on a light background if the user happens to be using a dark GTK theme.

Comment 6

[Emmy]

Attachment: issue.html

Can confirm that this is an issue in 62–64 whenever 'color' or 'background-color' are styled by the webpage. Attaching a better file to view styled vs unstyled side by side.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Hey, Dao, jljatone is interested in being mentored on this bug. Do you know someone who could mentor this?

Comment 8

[Dão Gottwald [:dao]]

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #7)
> Hey, Dao, jljatone is interested in being mentored on this bug. Do you know
> someone who could mentor this?

stransky or karlt? I'm not sure what the issue is here and that this is a good candidate for a mentored bug.

Comment 9

[Karl Tomlinson (:karlt)]

I don't know whether there is anyone available as a designated "mentor", but this may not be too hard to fix if the problem can be identified.

We have other bugs tracking the problem with the web page sets one of 'color' or 'background-color' but not the other.

The test case here indicates there is a problem even with the user-agent provided colors.

I have known some extensions and even KDE themes to write colors to userContent.css.
Does the bug reproduce with the steps in comment 0 even with a new Firefox profile?

Assuming the bug does still reproduce, the first step would be to identify whether it is the foreground or background color that does not match the colors seen in gtk3-widget-factory with the same theme.

Comment 10

[jljatone]

Karl, it certainly still reproduces. and the problem is likely the user-agent provided color.

basically: the web has standardized on white background/black text for the content, firefox should just default to that for the content pane regardless of the theming done by the desktop. emmy's comment is a wonderful overview of the issue.

Comment 11

[jljatone]

(attachment 2 [details] [diff] [review])[https://bugzilla.mozilla.org/attachment.cgi?id=9018150] is an example of the pane side by side where its still an issue.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

This is addressed by Bug 1527048.

Comment 13

[jljatone]

Martin,

this is still not fixed even though the issue marked as a duplicate has been marked as resolved and fixed in the latest version 67.0.

the very simple html test file included in this report (issue.html) still renders incorrectly for dark themes.