1466225 - Permafailing browser_inspector_highlighter-cssshape_06.js | This test exceeded the timeout threshold. when Gecko 62 merges to Beta on 14-06-2018

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=86bd65f4193bb4d637ef137f0a07dd404bc8abbe&group_state=expanded&selectedJob=181367542

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=181367542&repo=try&lineNumber=6191

09:31:53     INFO - Scaling from sw
09:31:53     INFO - Buffered messages logged at 09:31:46
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset sw moved right after sw scale - 
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset sw moved down after sw scale - 
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset width reduced after sw scale - 
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset height reduced after sw scale - 
09:31:53     INFO - Scaling from se
09:31:53     INFO - Buffered messages logged at 09:31:47
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset se moved right after se scale - 
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset se moved down after se scale - 
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset width reduced after se scale - 
09:31:53     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | #inset height reduced after se scale - 
09:31:53     INFO - Turn off shapes highlighter for #inset
09:31:53     INFO - Toggle shapes highlighter off for clip-path on #inset
09:31:53     INFO - Leaving test bound 
09:31:53     INFO - Buffered messages logged at 09:31:53
09:31:53     INFO - Removing tab.
09:31:53     INFO - Waiting for event: 'TabClose' on [object XULElement].
09:31:53     INFO - Got event: 'TabClose' on [object XULElement].
09:31:53     INFO - Tab removed and finished closing
09:31:53     INFO - Buffered messages finished
09:31:53     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
09:31:53     INFO - GECKO(1976) | MEMORY STAT | vsize 5195MB | residentFast 804MB | heapAllocated 155MB
09:31:53     INFO - TEST-OK | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js | took 96576ms

Might be a regression from Bug 1435373

Comment 1

[Intermittent Failures Robot]

19 failures in 655 pushes (0.029 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 19

Platform breakdown:
* macosx64-ccov: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466225&startday=2018-05-28&endday=2018-06-03&tree=trunk

Comment 2

[Intermittent Failures Robot]

20 failures in 99 pushes (0.202 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* try: 20

Platform breakdown:
* windows7-32: 6
* macosx64-ccov: 4
* linux64: 3
* linux32: 2
* macosx64-devedition: 1
* linux64-nightly: 1
* linux64-devedition: 1
* linux32-nightly: 1
* linux32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466225&startday=2018-06-04&endday=2018-06-04&tree=trunk

Comment 3

[Intermittent Failures Robot]

20 failures in 669 pushes (0.03 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 20

Platform breakdown:
* windows7-32: 6
* macosx64-ccov: 4
* linux64: 3
* linux32: 2
* macosx64-devedition: 1
* linux64-nightly: 1
* linux64-devedition: 1
* linux32-nightly: 1
* linux32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466225&startday=2018-06-04&endday=2018-06-10&tree=trunk

Comment 4

[Liz Henry (:lizzard)]

Gabriel, or pbrosset, can you help find an owner to fix this test or the underlying cause? We should be starting the beta 1 build today after the merge. While I'm not considering this as a blocker for 62 beta, I'd like it to be a priority so that we can rely on automated test coverage.

Comment 5

[Razvan Caliman [:rcaliman]]

I'll look into splitting this test. It loops though a lot checks for translating shapes in all directions.

Comment 6

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1466225 - (Part 1) Rename browser_inspector_highlighter-cssshape_06.js

Review commit: https://reviewboard.mozilla.org/r/251998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251998/

Comment 7

[Patrick Brosset <:pbro>]

Comment on attachment 8986708 [details]
Bug 1466225 - (Part 1) Rename browser_inspector_highlighter-cssshape_06.js

https://reviewboard.mozilla.org/r/251998/#review258456

This looks like moved code only, so I'm fine to R+ this quickly, but before doing so, I'd like to ask that you use the right commands to create those files so that the history is preserved.
Right now, those are 2 entirely new files and looking at the mercurial history won't get you very far and you'd have to understand that that old test file really is what you are looking for.
Instead, you can probably do this:
- copy 06.js into 06-scale.js
- remove whatever you need to remove from that new 06-scale.js file
- rename 06.js to 06-translate.js
- remove whatever you need to remove from 06-translate.js.

I think you can do these operations with either hg or git in a way that history will be preserved: from any of these 2 files you'll be able to just go up the chain of parents to see previous changes.

Comment 8

[Razvan Caliman [:rcaliman]]

Comment on attachment 8986708 [details]
Bug 1466225 - (Part 1) Rename browser_inspector_highlighter-cssshape_06.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251998/diff/1-2/

Comment 9

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1466225 - (Part 2) Split scale and transform shape path editor test to prevent exceeding max test run time.

Review commit: https://reviewboard.mozilla.org/r/252066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252066/

Comment 10

[Razvan Caliman [:rcaliman]]

Comment on attachment 8986708 [details]
Bug 1466225 - (Part 1) Rename browser_inspector_highlighter-cssshape_06.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251998/diff/2-3/

Comment 11

[Patrick Brosset <:pbro>]

Comment on attachment 8986708 [details]
Bug 1466225 - (Part 1) Rename browser_inspector_highlighter-cssshape_06.js

https://reviewboard.mozilla.org/r/251998/#review258514

Comment 12

[Patrick Brosset <:pbro>]

Comment on attachment 8986773 [details]
Bug 1466225 - (Part 2) Split scale and transform shape path editor test to prevent exceeding max test run time.

https://reviewboard.mozilla.org/r/252066/#review258516

Comment 13

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=60691142103511cc167993ffbdda46980987c136&selectedJob=184192738

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf183f5fce6a
(Part 1) Rename browser_inspector_highlighter-cssshape_06.js r=pbro
https://hg.mozilla.org/integration/autoland/rev/1f05dd7f51b5
(Part 2) Split scale and transform shape path editor test to prevent exceeding max test run time. r=pbro

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cf183f5fce6a
https://hg.mozilla.org/mozilla-central/rev/1f05dd7f51b5