Closed Bug 1466388 Opened Last year Closed Last year

tabs.Tab.active and tabs.Tab.highlighted not correct in android webext popup

Categories

(WebExtensions :: Frontend, enhancement)

Unspecified
Android
enhancement
Not set

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

Unexpectedly, the `selected` getter is used to provide the value of the `highlighted` and `active` properties in a tabs.Tab object.

https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/toolkit/components/extensions/parent/ext-tabs-base.js#582-583

On android, this means you can get

  let [tab] = await browser.tabs.query({active: true});
  tab.active; // false

if you run this in a browserAction popup.
Comment on attachment 8982864 [details]
Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab

https://reviewboard.mozilla.org/r/248720/#review255874
Attachment #8982864 - Flags: review?(lgreco) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/00f45773f03d
Android webext popup should not be considered to be the active or highlighted tab r=rpl
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/00f45773f03d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(oriol-bugzilla)
I added automated tests
Flags: needinfo?(oriol-bugzilla) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.