1466388 - tabs.Tab.active and tabs.Tab.highlighted not correct in android webext popup

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement)

Description

[Oriol Brufau [:Oriol]]

Unexpectedly, the `selected` getter is used to provide the value of the `highlighted` and `active` properties in a tabs.Tab object.

https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/toolkit/components/extensions/parent/ext-tabs-base.js#582-583

On android, this means you can get

  let [tab] = await browser.tabs.query({active: true});
  tab.active; // false

if you run this in a browserAction popup.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab

Review commit: https://reviewboard.mozilla.org/r/248720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248720/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8982864 [details]
Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab

https://reviewboard.mozilla.org/r/248720/#review255874

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00f45773f03d
Android webext popup should not be considered to be the active or highlighted tab r=rpl

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/00f45773f03d

Comment 5

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 6

[Oriol Brufau [:Oriol]]

I added automated tests