1466400 - Application panel is not localized

Status: VERIFIED FIXED

(DevTools :: Application Panel, defect)

Description

[Francesco Lodolo [:flod]]

I'm running 62.0a1 (2018-06-03) (64 bit), and the Italian localization was committed over 24 hours ago.
https://hg.mozilla.org/l10n-central/it/rev/d0ae1c11a8e6

I flipped devtools.application.enabled, which enables the panel, but it's in English.

I can find a file in omni.ja (localization/it/devtools/application.ftl), but it's in English, not localized.

Comment 1

[Axel Hecht [:Pike]]

https://hg.mozilla.org/mozilla-central/file/default/devtools/client/locales/jar.mn#l7:

  devtools (en-US/**/*.ftl)

Well, yes.

Pushing something to try.

Comment 2

[Axel Hecht [:Pike]]

Attachment: bug 1466400, don't hardcode en-US for devtools/client fluent at build time,

Review commit: https://reviewboard.mozilla.org/r/248832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248832/

Comment 3

[Axel Hecht [:Pike]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80ca083a4fde1905ec2cfc5e243b31a0dc4a4f20 is the try run, and I inspected the Italian linux builds

Comment 4

[Francesco Lodolo [:flod]]

Tested the Italian build, with some struggles (had to run it from the terminal, for some reasons…)
https://tools.taskcluster.net/groups/JYZCdWDuSUeo9GJJnFrs1Q/tasks/aEH3vA_dQ_yLH_kaKGaqGw/runs/0/artifacts

The application panel's content is correctly localized, the label itself is not (but that seems like a separate bug).

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8982986 [details]
bug 1466400, don't hardcode en-US for devtools/client fluent at build time,

https://reviewboard.mozilla.org/r/248832/#review255066

Stealing review from jdescottes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d08944831e26
don't hardcode en-US for devtools/client fluent at build time, r=flod

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d08944831e26

Comment 8

[Francesco Lodolo [:flod]]

Verified in 62.0a1 (2018-06-04) (64 bit)