1466441 - Skin color changes don't stick at androidify.com (race condition?)

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Karl Dubost💡 :karlcow]

This is a spin-off of https://webcompat.com/issues/13205
There might be a better component for it.
Tagging as [qf] because it seems related to a race/performance issue 
This can be reproduced on Firefox desktop with responsive mode and Firefox Android UA.


Steps to Reproduce:

1. Go to https://androidify.com/en/#/create
2. Try to assign one of the configuration
3. Click on a choice

Expected:
The Android mascot gets the choice made.

Actual:
The choice quickly appears and disappears.

_transitionTime: function (t) {
        if (t = t || 0, this.scrollerStyle[s.style.transitionDuration] = t + 'ms', !t && s.isBadAndroid && (this.scrollerStyle[s.style.transitionDuration] = '0.001s'), this.indicators) for (var e = this.indicators.length; e--; ) this.indicators[e].transitionTime(t)
      },

Working in Chrome Android.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Doesn't look like a DOM issue.

What does "Try to assign one of the configuration" mean? And I don't see "choice" anywhere. Does one need to click on the Android logo or what?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, I don't see how this is a perf issue either... I'm very suspicious about this bit:

  r.isBadAndroid=/Android /.test(t.navigator.appVersion)&&!/Chrome\/\d/.test(t.navigator.appVersion)

our navigator.appVersion on Android is "5.0 (Android 7.1.2)". Karl, is there any chance to confirm this is still broken spoofing window.navigator.appVersion?

Comment 3

[Thomas Wisniewski]

This page actually seems to be working for me on my Galaxy S7 Edge phone (I can "dress" the Android avatar).

However, when I spoof appVersion and userAgent (and other navigator properties) to match Chrome's, taps on icons that would change an article of "clothing" seem to be ignored, with no messages of note logged to the console.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Dressing the avatar works, what doesn't is changing the skin color.

Comment 5

[Thomas Wisniewski]

Ah, thanks. I re-tested and coloring the avatar doesn't work with or without the spoof for me (with a spoof, I only see a focus outline on the color when I tap it, but no other reaction; without a spoof I see the avatar flash to the new color before reverting).

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah, tried spoofing the appVersion with "general.appversion.override", and no such luck... Still it's not clear to me this is a style issue or a performance issue at all.

This is more likely related to transition events or pointer events, which is what that page seems to listen to...

Comment 7

[Kannan Vijayan [:djvj]]

I can repro this on my android (Pixel 1 + Firefox beta), but not on my linux x86 machine.  Changing the color of the droid does not work, and flickers and returns back to what it was.

Comment 8

[Daniel Holbert [:dholbert]]

(In any case, this is [qf-] since there doesn't seem to be jank... there may indeed be a race condition, but it seems entirely likely that the race condition is due to a logic / synchronization bug in either Firefox or in the site's JS.  There's no evidence that this is specifically a *perf* bug, at this point.)

Comment 9

[Mike Conley (:mconley) (:⚙️)]

vchin noticed that the Androidify page takes a really, really long time to finish loading with the Gecko Profiler enabled. I filed that as bug 1466927.

Comment 10

[Karl Dubost💡 :karlcow]

yup skin color is not working.

Comment 11

[Karl Dubost💡 :karlcow]

hair color too for me.

Comment 12

[Firefox Bug Husbandry Bot]

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Comment 13

[Firefox Bug Husbandry Bot]

See bug 1547409. Migrating whiteboard priority tags to program flags.

Comment 14

[Mike Taylor [:miketaylr]]

This issue no longer reproduces in Firefox Preview (didn't test in Fennec...). Let's close.