1466464 - Rename grow_memory to memory.grow and current_memory to memory.size everywhere

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

These renamings supplant the current "grow_memory" and "current_memory" encodings.

Also means we need to fix test cases, and there may be other fallout for all I know.

Comment 1

[Lars T Hansen [:lth]]

The new names are "memory.grow" and "memory.size".
https://github.com/WebAssembly/spec/blob/master/interpreter/text/lexer.mll#L318

It would probably behoove us to recognize the old opcodes for a while.

Comment 2

[Lars T Hansen [:lth]]

Attachment: bug1466464-memory_grow_and_size.patch

Minimal support for new syntax, and a minimal testing.

Comment 3

[Lars T Hansen [:lth]]

As I wrote in the patch comment for comment 2, the plan here is:

- land minimal support (that patch) and testing now
- land a massive renaming in the engine and test cases when the dust has settled for ref types, binary->text removal,
  and other big things that are in flight, after the summer
- remove support for the old syntax, eventually

Comment 4

[Julian Seward [:jseward]]

Comment on attachment 8988428 [details] [diff] [review]
bug1466464-memory_grow_and_size.patch

Looks OK to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6406d11016d
Part 1: Recognize memory.grow and memory.size syntax. r=jseward

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b6406d11016d

Comment 7

[Lars T Hansen [:lth]]

Attachment: Bug 1466464 - rename grow_memory and current_memory. r=bbouvier

Rename the uses of current_memory and grow_memory in wasm text content
as memory.size and memory.grow, since these are canonical.

Rename GrowMemory as MemoryGrow and CurrentMemory as MemorySize
everywhere in C++ source code, in honor of their new .wat names --
consistency is good. I chose "Memory" over "Mem" because I like the
longer name better, and I think we should rename uses of "Mem" as
"Memory" (but not in this patch).

Also handle some similar cases, like the growMemory_i32 and
currentMemory_i32 Instance methods.

Note a couple of changes in cranelift.

I did not remove support for the old .wat names yet, I figure we can
do that some other year, if ever.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/412fb2a5ae54
rename grow_memory and current_memory.  r=bbouvier

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/412fb2a5ae54

Comment 10

[Chris Mills [:cmills]]

Might impact documentation.