1466677 - Updates blocked due to old update_in_progress.lock

Status: NEW

(Toolkit :: Application Update, enhancement, P3)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I helped a Reddit user diagnose why they could never get an update to succeed. It turns out that they had an old update_in_progress.lock file that was impeding progress on the update. Once they removed that file, their updates were fixed.

I'm assuming that the user must have had a power outage or BSOD, thus preventing DELETE_ON_CLOSE from being effective.

Can we do anything about this?

eg What if the timestamp on the lock file is older than the elapsed time since the machine was started?

Comment 1

[Robert Strong (they/them - no direct email)]

The code also tries to remove the file in case this happens.
https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/updater/updater.cpp#3077

I would have thought that would be enough to handle this case. :(