1466814 - iOS sync integration tests are failing whilst waiting for weave:service:setup-complete

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The Firefox iOS sync integration tests are using TPS to sign into Firefox Accounts and perform an initial sync. Recently, the tests have started to fail whilst apparently waiting for weave:service:setup-complete.

We're expecting TPS to sign into Firefox Accounts and perform an initial sync. The signing in appears to work (we see a notification stating that sync will start shortly), however the sync does not complete and the test ultimately fails.

If you manually click to sync in the open instance of Firefox, then the test continues on. If you do nothing then eventually the Firefox instance will close and the test will fail.

The last few lines in the TPS log are:

> 2018-06-05 06:10:30.067 CROSSWEAVE INFO: ----------event observed: fxaccounts:onlogin
> 2018-06-05 06:10:30.068 CROSSWEAVE INFO: Logging into Weave.
> 2018-06-05 06:10:30.764 CROSSWEAVE INFO: Setting up wait for weave:service:setup-complete...

This suggests that the call to waitForSetupComplete in https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/services/sync/tps/extensions/tps/resource/tps.jsm#1191 never completes.

I used mozregression to determine a regression range, which concluded that https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a90972d695291bea4560ee5a8da77398ca9b42b1&tochange=1c6cfeb419c3157fc3dd6ae564358f7af8ca9cd1 is the cause of the regression, which is bug 1409208 and at least related to sync, so it could potentially be related.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:tcsc has this affected the TPS tests? I'm not sure where to see the results. Any ideas?

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1466814 - Remove the manual login call from TPS, since we'll log in anyway, and shouldn't be holding the sync lock

Review commit: https://reviewboard.mozilla.org/r/249466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249466/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8983614 [details]
Bug 1466814 - Remove the manual login call from TPS, since we'll log in anyway, and shouldn't be holding the sync lock

https://reviewboard.mozilla.org/r/249466/#review255656

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4db37ec137d6
Remove the manual login call from TPS, since we'll log in anyway, and shouldn't be holding the sync lock r=markh

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4db37ec137d6