1466816 - Font editor: Selected rule does not exist in 2-pane mode

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Razvan Caliman [:rcaliman]]

Steps to reproduce:

- Set DevTools Inspector in 2-pane mode
- Select the Fonts panel
- Close DevTools (this ensures that on re-open, Fonts is the default panel)
- Re-open DevTools and pich an element in the inspector
- Adjust toggles in the Fonts panel

Expected
- Changes are written to inline style

Result:
- No changes are written. There's an error in the toolbox:
TypeError: this.selectedRule is undefined

This happens because the Rule view was never instantiated (The Fonts panel was the default one to load). The rules from the Rule view don't yet exist.

Comment 1

[Razvan Caliman [:rcaliman]]

The Font Editor should rely on Element Style instead of Rule view to read and write properties.

Comment 2

[Razvan Caliman [:rcaliman]]

ElementStyle depends on the existence of Rule view. One solution is to force an instantiation of the Rule view even though it may not be visible.

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1466816 - Ensure rule models are available to the font editor even if the Rule view is not visible.

Review commit: https://reviewboard.mozilla.org/r/253540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253540/

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8988281 [details]
Bug 1466816 - Ensure rule models are available to the font editor even if the Rule view is not visible.

https://reviewboard.mozilla.org/r/253540/#review260166

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f76ef88d7e26
Ensure rule models are available to the font editor even if the Rule view is not visible. r=gl

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f76ef88d7e26

Comment 7

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: TypeError.png

I successfully reproduced the issue on Firefox Nightly 62.0a1 (2018-06-05) under Windows 10 (x64) using the STR from Comment 0.
The issue is verified fixed on Firefox Beta 63.0b13 under Windows 10 (x64), Ubuntu 16.04 (x64) and macOS 10.13.

The issue is reproducing on latest Firefox Nightly 64.0a1 (2018-10-09) under all three os-es mentioned above, and the error thrown in the browser console is "TypeError: this.selectedRule is undefined; can't access its "createProperty" property". I'll upload an attachment with the errors.

Comment 8

[Catalin Sasca, Desktop QA [:csasca]]

Hi Razvan, can you take a look over this ?

Comment 9

[Razvan Caliman [:rcaliman]]

This regression is tracked (and will be fixed) in Bug 1497950.

Comment 10

[Catalin Sasca, Desktop QA [:csasca]]

This issue was verified fixed, by bug 1497950.