Closed Bug 1466822 Opened 4 years ago Closed 4 years ago

Implement support for new blockquote, caption, and paragraph ARIA roles


(Core :: Disability Access APIs, enhancement, P3)




Tracking Status
firefox62 --- fixed


(Reporter: jdiggs, Assigned: jdiggs)


(Blocks 1 open bug)



(2 files)

As part of the effort to achieve "role parity" with HTML elements, ARIA has added blockquote, caption, and paragraph roles. Mappings can be found here:

Blocks: aria
Priority: -- → P3
Assignee: nobody → jdiggs
Attachment #8983399 - Flags: review?(surkov.alexander)
Comment on attachment 8983399 [details] [diff] [review]

Review of attachment 8983399 [details] [diff] [review]:

r=me, thanks!
Attachment #8983399 - Flags: review?(surkov.alexander) → review+
Pushed by
Implement support for new blockquote, caption, and paragraph ARIA roles. r=surkov
Keywords: checkin-needed
Backout by
Backed out changeset 671ec6415311 for failing test_txtcntr.html on a CLOSED TREE
That one failed test needs to be updated. SECTION is the wrong role (now). Sorry I missed it! Do I need to do resubmit the full patch or something else?
Flags: needinfo?(toros)
Flags: needinfo?(surkov.alexander)
Flags: needinfo?(jdiggs)
I have a meeting to go to in a few minutes. So I erred on the side of thoroughness. The attached is the same as the original, rolled-out patch but has the failing test updated so that it should now pass.

New question: Do I need a new review or can this be checked in?
Comment on attachment 8983487 [details] [diff] [review]
patch for landing (same as original but with previously failing test updated)

Carrying forward r+, since this just fixes the test. (I also reviewed the test change anyway.)
Attachment #8983487 - Flags: review+
try build was ok, closed tree, so marking as checking-needed
Flags: needinfo?(surkov.alexander)
Keywords: checkin-needed
We're also going to need to add a block quote role to IA2, since without it, Windows AT can't detect this. (They currently use tag:blockquote to detect this case.)
Filed an IA2 PR for this:
We can spin off a separate Mozilla bug to deal with that once we get this into IA2.
Pushed by
Implement support for new blockquote, caption, and paragraph ARIA roles r=Jamie
Keywords: checkin-needed
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: needinfo?(toros)
You need to log in before you can comment on or make changes to this bug.