1466822 - Implement support for new blockquote, caption, and paragraph ARIA roles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P3)

Description

[Joanmarie Diggs]

As part of the effort to achieve "role parity" with HTML elements, ARIA has added blockquote, caption, and paragraph roles. Mappings can be found here:

* https://rawgit.com/w3c/core-aam/master/#role-map-blockquote
* https://rawgit.com/w3c/core-aam/master/#role-map-caption
* https://rawgit.com/w3c/core-aam/master/#role-map-paragraph

Comment 1

[Joanmarie Diggs]

Attachment: 0001-Bug-1466822-Implement-support-for-new-blockquote-cap.patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8983399 [details] [diff] [review]
0001-Bug-1466822-Implement-support-for-new-blockquote-cap.patch

Review of attachment 8983399 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/671ec6415311
Implement support for new blockquote, caption, and paragraph ARIA roles. r=surkov

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91323a17cfa2
Backed out changeset 671ec6415311 for failing test_txtcntr.html on a CLOSED TREE

Comment 5

[Tiberius Oros[:tiberius_oros]]

Backed out changeset 671ec6415311 (bug 1466822) for failing test_txtcntr.html
 
Backout:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/91323a17cfa214729ada294f3e974e4cff3f25fb
 
Push with the failure:
 https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=671ec6415311aab033bda40cb9d80cd5f376b3d4
 
Failed job:
 https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=671ec6415311aab033bda40cb9d80cd5f376b3d4&selectedJob=181904519
 
Failure log file:
 https://treeherder.mozilla.org/logviewer.html#?job_id=181904519&repo=mozilla-inbound&lineNumber=4907

Comment 6

[Joanmarie Diggs]

That one failed test needs to be updated. SECTION is the wrong role (now). Sorry I missed it! Do I need to do resubmit the full patch or something else?

Comment 7

[Joanmarie Diggs]

Attachment: patch for landing (same as original but with previously failing test updated)

I have a meeting to go to in a few minutes. So I erred on the side of thoroughness. The attached is the same as the original, rolled-out patch but has the failing test updated so that it should now pass.

New question: Do I need a new review or can this be checked in?

Comment 8

[James Teh [:Jamie]]

Comment on attachment 8983487 [details] [diff] [review]
patch for landing (same as original but with previously failing test updated)

Carrying forward r+, since this just fixes the test. (I also reviewed the test change anyway.)

Comment 9

[alexander :surkov (:asurkov)]

try build was ok https://treeherder.mozilla.org/#/jobs?repo=try&revision=96343945dac9f0580f9a4537d64ef6f7a15317ac, closed tree, so marking as checking-needed

Comment 10

[James Teh [:Jamie]]

We're also going to need to add a block quote role to IA2, since without it, Windows AT can't detect this. (They currently use tag:blockquote to detect this case.)

Comment 11

[James Teh [:Jamie]]

Filed an IA2 PR for this:
https://github.com/LinuxA11y/IAccessible2/pull/6
We can spin off a separate Mozilla bug to deal with that once we get this into IA2.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a34a56825e8
Implement support for new blockquote, caption, and paragraph ARIA roles r=Jamie

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5a34a56825e8