1466844 - Please have all divider hairlines in hamburger menu door-hanger to be consistently aligned

Status: RESOLVED DUPLICATE of bug 1465337

(Firefox :: Menus, defect, P3)

Description

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2018-06-05 at 09.54.53.png

The divider hairline for sync accounts should be aligned to the divider line in "tracking protection". Please see screenshot for reference. Thanks!

Comment 1

[:Gijs (he/him)]

Can you provide a more detailed spec, ie how does this affect the cut/copy/paste and zoom buttons?

Also, have you considered that shifting those hairlines further left (esp. if you want to keep spacing/hairlines the same between the other edit/zoom buttons) this dramatically reduces the amount of space available for text, which is already a problem on non-English locales, requiring the menu to be much wider? (cf. bug 1366219, bug 1450294 etc.)

Finally, what added this tracking protection item? We should probably track this as a regression compared with that change. And, if that change may not ride the trains (I don't see it on beta), what do you want Firefox to do when the item isn't present? Add extra padding to the other items anyway?

Comment 2

[Amy Lee [:amylee] UX]

Attachment: Spec.jpg

Hi, 

I've attached a spec of the hairline that should be moved. This doesn't affect Edit/Zoom buttons as the hairline in Sync accounts should be moved to align with Edit/Zoom and also Tracking Protection (which landed in Nightly). Let me know if you have any additional questions.

Comment 3

[Amy Lee [:amylee] UX]

Hi, 

I've attached a spec of the hairline that should be moved. This doesn't affect Edit/Zoom buttons as the hairline in Sync accounts should be moved to align with only Tracking Protection (which landed in Nightly). Let me know if you have any additional questions.

Comment 4

[Amy Lee [:amylee] UX]

Attachment: Spec.jpg

Comment 5

[Amy Lee [:amylee] UX]

If Tracking Protection doesn't ride the trains than disregard the hairline change.

Comment 6

[:Gijs (he/him)]

(In reply to Amy Lee [:amylee] UX from comment #2)
> Created attachment 8983903 [details]
> Spec.jpg
> 
> Hi, 
> 
> I've attached a spec of the hairline that should be moved. This doesn't
> affect Edit/Zoom buttons as the hairline in Sync accounts should be moved to
> align with Edit/Zoom and also Tracking Protection (which landed in Nightly).

But the sync hairline already aligns with the zoom one (the one next to the full-screen icon), and doesn't align with the TP one... Are you trying to say it's OK for the TP/sync ones to not be aligned with the edit/zoom one?

Comment 7

[Amy Lee [:amylee] UX]

(In reply to :Gijs (he/him) from comment #6)
> (In reply to Amy Lee [:amylee] UX from comment #2)
> > Created attachment 8983903 [details]
> > Spec.jpg
> > 
> > Hi, 
> > 
> > I've attached a spec of the hairline that should be moved. This doesn't
> > affect Edit/Zoom buttons as the hairline in Sync accounts should be moved to
> > align with Edit/Zoom and also Tracking Protection (which landed in Nightly).
> 
> But the sync hairline already aligns with the zoom one (the one next to the
> full-screen icon), and doesn't align with the TP one... Are you trying to
> say it's OK for the TP/sync ones to not be aligned with the edit/zoom one?

Yes. It's much more obvious when the 2 items are stacked next to each other that the hairlines don't match up.