1466850 - "Accessible Information Unavailable" message is displayed on other tabs, if the feature is quickly enabled and disabled twice on one of them

Status: VERIFIED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Accessible Information Unavailable.mp4

[Affected versions]:
Firefox 62.0a1 (BuildId:20180604220149).
Firefox 61.0b10 (BuildId:20180604143143).

[Affected platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a new clean Firefox profile.
- The "Accessibility" option is checked in "Toolbar Options".

[Steps to reproduce]:
1. Start the Firefox browser with the profile from prerequisites.
2. Navigate to any website, press the "F12" key and enable Accessibility features.
3. Open a new tab, press the "F12" key and focus the "Accessibility" tab.
4. Quickly disable and re-enable Accessibility features two times.
5. Focus the other tab and observe the content of the Accessibility panels.

[Expected result]:
- Specific information related to the opened website is displayed.

[Actual result]:
- "Accessible Information Unavailable" text is displayed.

[Regression range]:
This seems to be a regression:

- Last good revision: 17ad383212f4a406afe066e2662b2c578064bff9
- First bad revision: aebf9e698f76913a66d13ecc9841fc005caa82b8
- Pushlog: https://goo.gl/YoL1i9

Looks like bug 1441187 introduced this behavior.

[Notes]:
- The issue is still reproducible after the browser is restarted.
- Attached a screen recording with the issue.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Cosmin, I have a build with a potential fix for the issue -  https://treeherder.mozilla.org/#/jobs?repo=try&revision=55b4f36cf3b9e099a6a9086f4dfc57c287a1d348. Could you see if it works for you (+ no new regressions)?

Thanks

Comment 2

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have retested this issue and is no longer reproducible on the provided Nightly try build. I have also performed testing on the try build and I haven't found any new regression related to Accessibility features.
Tested on Windows 10 x64, Windows 7 x64, Mac 10.13 and Arch Linux 4.12.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1466850 patch

Clear the promise when fetching children when the walker is reset.

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Cosmin, I am curious if this is a good candidate for an uplift to beta or is it too of an edge case?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b49d180069
reset children request when walker is being reset. r=pbro

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Considering the fact that this issue is quite an edge case scenario and since the Accessibility feature is preffed off on Firefox Beta 61,I don't consider that an uplift is necessary. Also the shield study will be released only on Firefox Developer Edition 62 which will include the fix for this bug.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Cosmin Muntean [:CosminMCG], Desktop Engineering QA from comment #6)
> Considering the fact that this issue is quite an edge case scenario and
> since the Accessibility feature is preffed off on Firefox Beta 61,I don't
> consider that an uplift is necessary. Also the shield study will be released
> only on Firefox Developer Edition 62 which will include the fix for this bug.

Thanks

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b4b49d180069

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I'm cleaning up the old issues. Based on comment 2 this issue was fixed and verified. Considering this I will mark the bug as verified - fixed.
However, now the feature is enabled by default.