1466921 - Upgrade Phabricator to week 2018/22

Status: RESOLVED FIXED

(Conduit :: Phabricator, enhancement)

Description

[David Lawrence [:dkl]]

https://mana.mozilla.org/wiki/display/EW/Phabricator+-+Update+Process

Comment 1

[David Lawrence [:dkl]]

Attachment: github pr #53

Comment 2

[Phabricator Automation]

Attachment: Promote 2018 Week 22

Promote 2018 Week 22

Comment 3

[David Lawrence [:dkl]]

phabricator-dev has been deployed and QA is ready to begin.

Comment 4

[Chris Hartjes [:grumpy][:chartjes]]

QA ran the following tests:

Creating a revision is successful - PASS
Updating a revision with an amended commit is successful - PASS
Creating a secure revision is successful - PASS
Adding a secure bug to an existing revision locks it down - PASS
Creating a revision checks the bug ID - PASS
Creating multiple revisions with the same bug ID is successful - PASS
Requesting and leaving a review on a revision is successful - PASS
Resigning as a reviewer removes R+ - PASS
Plan changes clears R+'s - FAIL (verified twice) r+ still exists
Abandoning a revision obsoletes the attachment - PASS
Reclaiming a revision unobsoletes the attachment - PASS

Comment 5

[Chris Hartjes [:grumpy][:chartjes]]

After IRC discussion with dkl it has been determined that the FAILing test is not actually failing and that the observed behaviour is correct.

QA validates this build and is okay with a production push.

Comment 6

[David Lawrence [:dkl]]

All done. Closing.